D10618: Fix ComboBox & mode description for image fill mode

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5bf2d077895b: Fix ComboBox  mode description for 
image fill mode (authored by sharvey, committed by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10618?vs=27508=27527

REVISION DETAIL
  https://phabricator.kde.org/D10618

AFFECTED FILES
  applets/mediaframe/package/contents/config/main.xml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/mediaframe/package/metadata.desktop

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added a comment.


  In D10618#209247 , @ngraham wrote:
  
  > Thanks! I'll let @davidedmundson push this if he's satisfied with the 
changes.
  
  
  Sounds fair to me. Thanks for the guidance. Now back to trying to fix my 
video drivers...

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Nathaniel Graham]

ngraham added a comment.


  Thanks! I'll let @davidedmundson push this if he's satisfied with the changes.

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added a comment.


  Arabic translations REMOVED. Now I understand. I thought I had typo'ed and 
accidentally changed them originally. I'm trying, I'm trying!

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey updated this revision to Diff 27508.
sharvey added a comment.


  - Removed new Arabic translations from metadata.desktop

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10618?vs=27507=27508

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

AFFECTED FILES
  applets/mediaframe/package/contents/config/main.xml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/mediaframe/package/metadata.desktop

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Nathaniel Graham]

ngraham added a comment.


  No worries! There's always a bit of a learning curve here. You might check 
out https://community.kde.org/Infrastructure/Phabricator, which outlines some 
sane workflows for Phabricator.
  
  The new Arabic translations in `applets/mediaframe/package/metadata.desktop` 
still need to be removed FYI.

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added a comment.


  My apologies. I thought his changes were already made. I'm new to this whole 
process. I don't know how the Text item changed; I didn't do any work on that 
file. And now the change doesn't show up in the resubmitted diff. It is 
currently a Label and works just fine.
  
  My mistake was doing my work on the copy installed in my system as opposed to 
the version pulled fresh from git. I assumed they were the same. I won't make 
that mistake again.

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey updated this revision to Diff 27507.
sharvey added a comment.


  - Change "Text" item to preferred "Label" item

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10618?vs=27433=27507

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

AFFECTED FILES
  applets/mediaframe/package/contents/config/main.xml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/mediaframe/package/metadata.desktop

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Also please address @davidedmundson's requests and revert the changes 
from Label to Text and the new Arabic translations (translation is done via 
another process).

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added a comment.


  My email is
  
  bund...@gmail.com
  
  My KDE Identity username is
  
  sharvey
  
  Although if you see me on IRC, I am
  
  bundito
  
  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Nathaniel Graham]

ngraham added a comment.


  We'll need an email address for you first. What's a good one?

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added a comment.


  Can someone (David?) land this for me? I don't have the superpowers to do it 
myself.
  
  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  1 minor fix.
  
  Make sure you don't change the Arabic translations when pushing.

INLINE COMMENTS

> ConfigPaths.qml:161
>  
> -Label {
> +Text {
>  id: pathText

Always label.

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey added reviewers: Plasma, mart, davidedmundson.
sharvey added a comment.


  My first bugfix. Un-mangled the ConfigGeneral.qml file for the stock Media 
Frame plasmoid, based on bug 390571. Hope I chose the right reviewers.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10618

To: sharvey, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  BUG: 390571
  
  Reworked ConfigGeneral.qml to properly display ComboBox for image
  fill modes, along with descriptive message explaining fill mode.
  
  Changed default change interval (main.xml) to 10.0 instead of the
  random-appearing 6.8 original.
  
  (Minor) Capitalized "Frame" in plasmoid title as "Media Frame"

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10618

AFFECTED FILES
  applets/mediaframe/package/contents/config/main.xml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/mediaframe/package/contents/ui/ConfigPaths.qml
  applets/mediaframe/package/metadata.desktop

To: sharvey
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart