D10878: Changed default context menu entries on the desktop

2018-02-27 Thread Alex Nemeth
anemeth abandoned this revision.
anemeth added a comment.


  This is not removing settings, just disabling them by default. These could be 
enabled in the standard right click menu settings again.
  
  F5732210: Képkivágás.PNG 
  
  I'll abandon this revision because the consensus is people don't like the 
simplified context menu.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: mart, rizzitello, zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D10878: Changed default context menu entries on the desktop

2018-02-27 Thread Marco Martin
mart added a comment.


  -1 as well, removing entries is a no go, especially I won't accept the 
removal of anything related to widget manipulation

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: mart, rizzitello, zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Chris Rizzitello
rizzitello added a comment.


  Just wanted to point out that as proposed in a Desktop view the contect menu 
would contain only three items Lock screen , Leave and Configure Desktop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: rizzitello, zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Vlad Zagorodniy
zzag added a comment.


  -1, sorry. I totally agree with @hein (except the part about regular usage).
  
  > Why not just create a new submenu called "Manage"
  
  No one will see what's inside. I don't discover what's inside of each submenu 
and I think so others.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Joshua Noack
jnoack added a comment.


  I agree, the context menu looks really convoluted. But what happens when the 
cashew is disabled and the desktop is empty? There would be no way to add 
widgets.
  
  Why not just create a new submenu called "Manage" or something instead for:
  
  - Add Widgets
  - Add Panel
  - The lock toggle
  
  and maybe even put "Configure Desktop" in there.
  
  This would already improve the current menu a lot:
  
  - Manage...
- Add Widget
- Add Panel
- Lock
- Configure Desktop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: jnoack, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Eike Hein
hein added a comment.


  I'm quite heavily -1 on this.
  
  This is removing various entries that I personally use regularly and that I 
think users rely on:
  
  - Add Widgets
  - Add Panel
  - The lock toggle
  
  These are only "unnecessary" if you assume people actually understand and use 
the desktop toolbox, which I don't believe (plus we allow disabling it, which 
means these actions become wholly inacessible). I'd wager vastly more people 
use these via the context menu.
  
  It also removes an action that's part of the Plasma design, the associated 
app action that a containment/applet can change dynamically, and that's quite 
useful together with Folder View.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Alex Nemeth
anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Plasma, VDG.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D10878: Changed default context menu entries on the desktop

2018-02-26 Thread Alex Nemeth
anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10878

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: anemeth
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart