D11056: [mediacontroller applet] Use media playback status icons
This revision was automatically updated to reflect the committed changes. Closed by commit R120:04dc4c9d2217: [mediacontroller applet] Use media playback status icons (authored by romangg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11056?vs=28906=28907 REVISION DETAIL https://phabricator.kde.org/D11056 AFFECTED FILES applets/mediacontroller/contents/ui/main.qml To: romangg, #plasma, andreask, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg updated this revision to Diff 28906. romangg added a comment. - Also change tooltip icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11056?vs=28902=28906 BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 AFFECTED FILES applets/mediacontroller/contents/ui/main.qml To: romangg, #plasma, andreask, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
broulik added a comment. Can you please also update the tooltip REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma, andreask, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg updated this revision to Diff 28902. romangg added a comment. Rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11056?vs=28713=28902 BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 AFFECTED FILES applets/mediacontroller/contents/ui/main.qml To: romangg, #plasma, andreask Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma, andreask Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg added a dependency: D11063: [mediacontroller applet] Reorder elements. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg added a comment. Should we add a fallback mechanism in case the icon pack does not contain the media playback state icons? I mean as a fallback the normal media-playback-start and pause icons again as it is now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg added a dependency: D11054: Add media status icons. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11056: [mediacontroller applet] Use media playback status icons
romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Instead of using the action icons to indicate the current state use the new media playback status icons. This is an alternative solution to the problem that the mediacontroller applet icon in the system tray and the play/pause controll in the player are always the opposite. While it is still the opposite icon there is now a slight visual difference to show that these icons mean different things. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 AFFECTED FILES applets/mediacontroller/contents/ui/main.qml To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
