D11069: [WIP][kdecoration] refine shadows

2018-03-14 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29540.
zzag added a comment.


  - tweak opacity values
  - bump strength to 100%
  - don't use aggregate initialization(available only in >= C++20)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29197=29540

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-10 Thread Nathaniel Graham 
ngraham added a comment.


  Looks pretty nice to me!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-10 Thread Vlad Zagorodniy 
zzag planned changes to this revision.
zzag added a comment.


  change the way default params are represented(right now, it's js-ish)
  
  ---
  
  I'll take a break from working on these shadows.
  
  Current look:
  F5748966: desktop.png 
  
  Menu shadows:
  F5748969: kstyle-shadows.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-10 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29197.
zzag added a comment.


  - bump strength to 85%

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29127=29197

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29127.
zzag added a comment.


  - move libbreezecommon to another patch

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29121=29127

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag added a comment.


  - split this patch(deco shadow patch and libbreezecommon patch)
  - fix params issues

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29121.
zzag added a comment.


  - fix KDE4 build

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29072=29121

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag added a comment.


  TODOs(kdecoration and kstyle):
  
  - revise params
  - document how to fill params
  
  @hpereiradacosta: could you please give it first round review code?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart