D11142: Add ConnectionCheck for Dash Cards

2018-03-08 Thread Aditya Mehra 
Aiix added inline comments.

INLINE COMMENTS

> yurchor wrote in main.qml:132
> Is it necessary to use "" between "the" and "internet" in this message? 
> Thanks in advance for your answer.

Thanks for reviewing this, I wasn't sure if there is general issue on using 
Unicode symbols in strings and rather a shortcut to not using a icon instead, 
will fix it.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D11142

To: Aiix, #plasma
Cc: yurchor, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

2018-03-07 Thread Yuri Chornoivan 
yurchor added inline comments.

INLINE COMMENTS

> main.qml:132
> +   if(!connectCtx){
> +   var conError = i18n("I am not connected to the  internet, 
> Please check your network connection")
> +   convoLmodel.append({"itemType": "NonVisual", "InputQuery": 
> conError});

Is it necessary to use "" between "the" and "internet" in this message? Thanks 
in advance for your answer.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D11142

To: Aiix, #plasma
Cc: yurchor, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

2018-03-07 Thread Aditya Mehra 
Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Check if there is an internet connection available before displaying 
information cards
  
  - Ping example.com to check connection availability
  - Wait for active internet connection to connect to plasma geolocation 
datasource
  - Do not display information cards in not connected as they are dependent on 
GeoLocation data

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11142

AFFECTED FILES
  CMakeLists.txt
  plasmoid/contents/ui/main.qml
  plugin/CMakeLists.txt
  plugin/connectioncheck.cpp
  plugin/connectioncheck.h
  plugin/mycroftplasmoidplugin.cpp

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

2018-03-07 Thread Aditya Mehra 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:7a9795631062: Add ConnectionCheck for Dash Cards 
(authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11142?vs=28975=28976

REVISION DETAIL
  https://phabricator.kde.org/D11142

AFFECTED FILES
  CMakeLists.txt
  plasmoid/contents/ui/main.qml
  plugin/CMakeLists.txt
  plugin/connectioncheck.cpp
  plugin/connectioncheck.h
  plugin/mycroftplasmoidplugin.cpp

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart