D11175: [kstyle] Refine shadows

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:5a15e8ed40e1: [kstyle] Refine shadows (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=35491=37268

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] Refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 35491.
zzag added a comment.


  Rebase.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=34595=35491

BRANCH
  refine-shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 34595.
zzag added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=31810=34595

BRANCH
  refine-shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 31810.
zzag added a comment.


  Rebase.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=30238=31810

BRANCH
  refine-shadows-kstyle

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#231649 , 
@hpereiradacosta wrote:
  
  > Still, you'll probably need to rebase your patch to the current master 
(because of the fix I introduced above)
  
  
  I already rebased onto master(7f18aa39ed261828c774094c404ee7a3ed3b060e 
).

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  
  
  >> I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  >>  I also have a local patch for fixing the MDI shadows on top of this 
patch, if you are interested.
  > 
  > MDI shadows have another problem? Is it because of this patch?
  
  Yes (another problem) and no (because of this patch).
  
  As you quoted on IRC, they used the raw shadowSize enum as an actual value. 
This was correct for the old-old shadows, but not any more when Nathan and 
myself switched to using an enum. Thats what required fixing, disregarding 
whether your patch gets landed or not.
  
  > 
  > 
  >> Note that I also commented on the possible horizontal offset that you left 
in your implementation, for the kdecoration part. It also applies here. I would 
drop it :)
  > 
  > Yeah, I added them to keep everything consistent(the box shadow helper 
expects QPoint to be an offset). I'd like to keep it, if you don't mind. :)
  
  Ok. No problem. 
  Still, you'll probably need to rebase your patch to the current master 
(because of the fix I introduced above)

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  I'd like to land it but KWin patches haven't landed yet.

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#231614 , 
@hpereiradacosta wrote:
  
  > In D11175#231610 , @zzag wrote:
  >
  > > Fix MDI child window shadows.
  >
  >
  > I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  >  I also have a local patch for fixing the MDI shadows on top of this patch, 
if you are interested.
  
  
  MDI shadows have another problem? Is it because of this patch?
  
  > Note that I also commented on the possible horizontal offset that you left 
in your implementation, for the kdecoration part. It also applies here. I would 
drop it :)
  
  Yeah, I added them to keep everything consistent(the box shadow helper 
expects QPoint to be an offset). I'd like to keep it, if you don't mind. :)

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Ship it, thanks !

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag requested review of this revision.
zzag added a comment.


  F5762842: mdi-shadows.png 
  
  //Shadows in Qt Designer//
  
  It's hard to see them because background is gray... I couldn't find another 
app with MDI, sorry. :(

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 30238.
zzag added a comment.
This revision is now accepted and ready to land.


  - fix MDI child window shadows

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=29541=30238

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D11175#231610 , @zzag wrote:
  
  > Fix MDI child window shadows.
  
  
  I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  I also have a local patch for fixing the MDI shadows on top of this patch, if 
you are interested. 
  Note that I also commented on the possible horizontal offset that you left in 
your implementation, for the kdecoration part. It also applies here. I would 
drop it :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.
zzag added a comment.


  Fix MDI child window shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  ship it. 
  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Please note, I didn't add getters because params struct:
  
  - is internal
  - that's const
  - that's struct and structures have public fields by default

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a subscriber: abetts.
zzag added a comment.


  See current menu shadows in revision's summary.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Hugo, could you please review it?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart