D11498: Install firefox's native messaging host to LIBDIR

2018-03-20 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:5846f3bfed56: Install firefoxs native messaging 
host to LIBDIR (authored by heikobecker).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11498?vs=29938=29997

REVISION DETAIL
  https://phabricator.kde.org/D11498

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma, bshah, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11498: Install firefox's native messaging host to LIBDIR

2018-03-20 Thread Bhushan Shah
bshah added a comment.


  See : https://wiki.mozilla.org/WebExtensions/Native_Messaging#Host_Manifests

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11498

To: heikobecker, #plasma, bshah, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11498: Install firefox's native messaging host to LIBDIR

2018-03-20 Thread Bhushan Shah
bshah added a comment.


  That's interesting... because umm, firefox specs says DATADIR should work™

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11498

To: heikobecker, #plasma, bshah, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11498: Install firefox's native messaging host to LIBDIR

2018-03-19 Thread Heiko Becker
heikobecker created this revision.
heikobecker added reviewers: Plasma, bshah, broulik, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  0d92aba10fd9402c184ef77706a87efa0d436c3e 
 
changed this from a hard
  coded value (/usr/lib/...) to a KDE_INSTALL_ variable (yay!), but
  used an incorrect one.

TEST PLAN
  Extension communicates with the host again

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11498

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma, bshah, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart