D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

2018-04-09 Thread Alexey Min
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do 
not require OpenGL 3.2 (authored by alexeymin).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12003?vs=31536&id=31731

REVISION DETAIL
  https://phabricator.kde.org/D12003

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: alexeymin, #plasma, graesslin, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

2018-04-06 Thread Alexey Min
alexeymin added a comment.


  On wayland, without this patch with OpenGL 3.2 version requested, it fails 
with error: 
  F5796592: wayland before.png 
  and outputs in terminal:
  
Could not get requested OpenGL profile, requested 
QSurfaceFormat::OpenGLContextProfile(CoreProfile) got 
QSurfaceFormat::OpenGLContextProfile(NoProfile)
Could not get requested OpenGL profile, requested 
QSurfaceFormat::OpenGLContextProfile(CompatibilityProfile) got 
QSurfaceFormat::OpenGLContextProfile(NoProfile)
  
  With this fix, it loads, and shows that opengl version is only 2.1:
  F5796598: wayland after.png 
  
  With this fix, on X11:
  F5796603: kinfocenter X11 after.png 
  
  This code in kinfocenter was added 4 years ago in commit: 
https://cgit.kde.org/kinfocenter.git/commit/?id=dc62d965ff21c9840b3284acbb91f7b44bd9e394
 from review: https://git.reviewboard.kde.org/r/115952/ but I don't understand 
why 3.2 is required. :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12003

To: alexeymin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

2018-04-06 Thread Alexey Min
alexeymin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
alexeymin requested review of this revision.

REVISION SUMMARY
  Removing the requirement of 3.2 version just fixes it for my AMD RX560 on 
amdgpu opensource driver, which only has 2.1 version.

TEST PLAN
  Run kinfocenter, choose Graphical information - OpenGL tab. It should open 
without errors.

REPOSITORY
  R102 KInfoCenter

BRANCH
  fix_wayland_opengl

REVISION DETAIL
  https://phabricator.kde.org/D12003

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: alexeymin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart