D12641: Workaround Device Notifier showing an error despite volume being mounted correctly
mlibera updated this revision to Diff 33433. mlibera edited the summary of this revision. mlibera added a comment. @anthonyfieroni I think it makes sense, I've tested it and it works. @bruns I've tried to mimic the code that was already there. With this revised version there is no extra code, so I guess no need for comments? I've never used phabricator and have no idea what parent revision is or what am I expected to do with it, sorry. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12641?vs=33414=33433 REVISION DETAIL https://phabricator.kde.org/D12641 AFFECTED FILES soliduiserver/deviceserviceaction.cpp To: mlibera, #plasma, broulik, #frameworks Cc: anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D12641: Workaround Device Notifier showing an error despite volume being mounted correctly
anthonyfieroni added inline comments.
INLINE COMMENTS
> deviceserviceaction.cpp:91
> +} else {
> +connect(access, ::StorageAccess::accessibilityChanged,
> +this, ::_k_accessibilityChanged);
Why not use it in all cases?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D12641
To: mlibera, #plasma, broulik, #frameworks
Cc: anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D12641: Workaround Device Notifier showing an error despite volume being mounted correctly
bruns added a comment. -1 Coding style - you could use a lambda here Lacking comment, as its not obvious why the code is needed parent revision is missing ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #frameworks Cc: bruns, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D12641: Workaround Device Notifier showing an error despite volume being mounted correctly
davidedmundson added a comment. > This doesn't fix the underlying issue but works around it by double checking if a device is really mounted and if not waiting for it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D12641: Workaround Device Notifier showing an error despite volume being mounted correctly
mlibera created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlibera requested review of this revision. REVISION SUMMARY For some reason a signal is being received about a device finishing setup before it's actually mounted, resulting in kde-open5 being called with and empty path instead of a mount point. This doesn't fix the underlying issue but works around it by double checking if a device is really mounted and if not waiting for it. BUG: 370975 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 AFFECTED FILES soliduiserver/deviceserviceaction.cpp To: mlibera Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
