D12997: Add new api to support window tabs

[Martin Flöser]

graesslin added a comment.


  In D12997#354190 , @zzag wrote:
  
  > Ping?
  
  
  The code doesn't work yet, the API is still lacking some functionality

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D12997

To: graesslin, #kwin, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12997: Add new api to support window tabs

[Vlad Zagorodniy]

zzag added a comment.


  Ping?

INLINE COMMENTS

> decoration.h:126
> + * Decoration.
> + * @since 5.14
> + * @see client

Looks like the version has to be bumped. :-)

> decoratedclientprivate.h:144
> +protected:
> +explicit WindowTabsEnabledDecoratedClientPrivate(DecoratedClient 
> *client, Decoration *decoration);
> +};

Is there a reason why this constructor is explicit?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D12997

To: graesslin, #kwin, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12997: Add new api to support window tabs

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  The new API basically just provides a vector of DecoratedClient
  referring to the window tabs. This was the idea on how to implement
  window tabs I had back when starting the implementation of KDecoration2.
  There are a few more requests to close a specific tab and to activate a
  tab.
  
  On the private side a new subclass is added, which KWin can implement to
  provide window tab support.

TEST PLAN
  Early review and KWin doesn't use the new API yet, so completely
  untested. Will not merge prior to using the API in KWin.

REPOSITORY
  R129 Window Decoration Library

BRANCH
  window-tab-api

REVISION DETAIL
  https://phabricator.kde.org/D12997

AFFECTED FILES
  src/decoration.cpp
  src/decoration.h
  src/private/decoratedclientprivate.cpp
  src/private/decoratedclientprivate.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart