D13062: Don't manipulate foreign windows

2018-05-24 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:6288079d936b: Dont manipulate foreign windows 
(authored by broulik).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13062?vs=34712=34797

REVISION DETAIL
  https://phabricator.kde.org/D13062

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: broulik, #plasma, davidedmundson, graesslin
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13062: Don't manipulate foreign windows

2018-05-23 Thread Martin Flöser 
graesslin accepted this revision.
graesslin added a comment.


  Please as bugfix to 5.12 branch.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D13062

To: broulik, #plasma, davidedmundson, graesslin
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13062: Don't manipulate foreign windows

2018-05-23 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 34712.
broulik added a comment.


  - Remove accidental coding style change

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13062?vs=34711=34712

REVISION DETAIL
  https://phabricator.kde.org/D13062

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13062: Don't manipulate foreign windows

2018-05-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  I noticed that Chrome's window had the property
  
_KDE_NET_WM_DESKTOP_FILE(UTF8_STRING) = "org.kde.kdialog"
  
  and it uses `kdialog --attach` for a Save As dialog with proper parent dimming
  
  - Attached `kdialog` to another window, it never got its desktop file name 
forcefully changed to that.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D13062

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart