broulik created this revision.
broulik added reviewers: Plasma, fvogt, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Chrome doesn't run extensions in incognito mode by default whereas Firefox
does.
Filter out incognito tabs from Browser Tabs Runner as well as disable media
controls for those sites to prevent accidental private information leak.
TEST PLAN
- Favicons still work for normal tabs in runner
- Incognito tabs weren't found anymore in runner
- Incognito tabs are still found when extension is explicitly whitelisted in
Chrome
- Media controls still worked for normal pages
- Media controls were not offered for incognito pages
Didn't touch kde connect as that is something you explicitly have to do on
the actual page and same for downloads I guess
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13068
AFFECTED FILES
extension/extension.js
To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
