D13119: Abort transaction on PK dependency resolution error
This revision was automatically updated to reflect the committed changes. Closed by commit R134:ee8e49422118: Abort transaction on PackageKit errors (authored by arojas). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34886=34907 REVISION DETAIL https://phabricator.kde.org/D13119 AFFECTED FILES libdiscover/backends/PackageKitBackend/PKTransaction.cpp To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13119: Abort transaction on PK dependency resolution error
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks better, thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13119 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13119: Abort transaction on PK dependency resolution error
arojas updated this revision to Diff 34886. arojas added a comment. Remove wrong check for !m_proceedFunctions.isEmpty() REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34881=34886 REVISION DETAIL https://phabricator.kde.org/D13119 AFFECTED FILES libdiscover/backends/PackageKitBackend/PKTransaction.cpp To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13119: Abort transaction on PK dependency resolution error
arojas updated this revision to Diff 34881. arojas added a comment. Check for ExitStatus in cleanup() and move setStatus there REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34873=34881 REVISION DETAIL https://phabricator.kde.org/D13119 AFFECTED FILES libdiscover/backends/PackageKitBackend/PKTransaction.cpp To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13119: Abort transaction on PK dependency resolution error
apol added a comment. Looks like it's missing checking the `exit` argument in ::cleanup() for `ExitFailed` no? Can you check if in this case we're getting the an ExitFailed? If so the setStatus should go there. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13119 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13119: Abort transaction on PK dependency resolution error
arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY If PackageKit throws a dependency resolution error, abort the transaction instead of finishing it anyway (potentially breaking the user's installation). This is far from ideal, but prevents Discover from performing destructive operations while the PackageKit issues are fixed BUG: 394327 TEST PLAN Tried to remove a package which is an optional dependency of another one on Arch (which gives a warning that PK can't handle), the operation was aborted. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13119 AFFECTED FILES libdiscover/backends/PackageKitBackend/PKTransaction.cpp To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
