D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Nathaniel Graham]

ngraham added a comment.


  Functionally, that'll probably fix the bug, but I don't expect the user 
complaints to abate, just change to "Why can I uselessly drag my task manager 
entries?"
  
  I still think this deserves a larger discussion regarding whether dragging 
apps from task manager tasks onto panels or the desktop is a use case that we 
ought to tiptoe around so much. Is it really such a common use case?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Nathaniel Graham]

ngraham added a comment.


  So under that proposal, the visible drag would still happen, but not do 
anything if you drop on an app instead of a containment, right?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Chris Holland]

Zren abandoned this revision.
Zren added a comment.


  No prob.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Eike Hein]

hein added a comment.


  @Zren Would you be OK with abandoning this patch (which I btw got close to 
accepting before I read David's comment, so thanks for your persistence on 
this)? I would then have a go at implementing David's idea today / this week.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Eike Hein]

hein added a comment.


  I like David's idea.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Nathaniel Graham]

ngraham added a comment.


  Maybe we need to stay back and get specific about what we're trying to 
support with the ability to drag-and-drop apps from the Task manager. Then we 
can figure whether or not that's actually valuable for our users, and if so, 
what's the best way to provide it while not causing problems of the sort 
detailed in https://bugs.kde.org/show_bug.cgi?id=390034.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[David Edmundson]

davidedmundson added a comment.


  Question/alternative proposal as I don't like any regressions.
  
  The main problem is we have a data under the mimetype text/url which is why 
apps keep processing it. 
  We use this data for drag and drop to pins/desktop but couldn't data that be 
under a custom x-plasma/asdfasdf mimetype if we also ported the other bit(s) of 
code to accept that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[David Edmundson]

davidedmundson added a comment.


  Please don't link to reddit. We do not do development on social media.
  
  Is it necessary to drop the distance threshold?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

To: Zren
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  This prevents the user from accidentally dragging a `.desktop` file into 
their browser.
  
  BUG: 390034
  
  - Previous discussion from December: https://phabricator.kde.org/D8564#162784
  - Recently discussed on Reddit: 
https://www.reddit.com/r/kde/comments/8mdwlf/prevent_dragging_window_icons_outside_the_task/
  
  **Alternative #1:** Cancel the drag if the mouse leaves the taskmanager area 
in under 800ms since the mouse was pressed. This lets you quickly rearrange 
tasks, but requires "copying" the `.desktop` file to be deliberate.
  
  F5872098: screen-2018-05-26_20.44.25.mp4 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13162

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart