D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e108d7e90e36: Teach ContainmentInterface::processMimeData 
how to handle Task Manager drops (authored by hein).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13275?vs=35463=35656

REVISION DETAIL
  https://phabricator.kde.org/D13275

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: hein, davidedmundson, Zren, mart
Cc: ngraham, zzag, kde-frameworks-devel, plasma-devel, michaelh, bruns

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

[Eike Hein]

hein updated this revision to Diff 35463.
hein added a comment.


  Fix last minute build error.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13275?vs=35371=35463

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13275

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: hein, davidedmundson, Zren, mart
Cc: ngraham, zzag, kde-frameworks-devel, plasma-devel, michaelh, bruns

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

[Eike Hein]

hein created this revision.
hein added reviewers: davidedmundson, Zren, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
hein requested review of this revision.

REVISION SUMMARY
  To explicitly confine Task Manager drops to Plasma and avoid accidental
  drops on other apps, D13274  makes it 
store task launcher URLs in a special
  internal MIME type instead of the generic text/url one. This change to
  processMimeData() adds the necessary conversion back.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13275

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: hein, davidedmundson, Zren, mart
Cc: kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this doesn't build for me (Neon dev unstable, deps built from source):
  

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:
 In member function 'void ContainmentInterface::processMimeData(QMimeData*, 
int, int, KIO::DropJob*)':

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:52:
 error: 'mimeCopy' was not declared in this scope
 QList urls = 
{QUrl(QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkd
^

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:126:
 error: could not convert '{}' from '' to 'QList'
 
QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkdeplasmataskmanager_taskurl"};

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13275

To: hein, davidedmundson, Zren, mart
Cc: ngraham, zzag, kde-frameworks-devel, plasma-devel, michaelh, bruns