D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None"

2018-07-03 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:50b1acf4016a: [Splash Screen KCM] Fix no 
thumbnail icon for None (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13864?vs=37092=37109

REVISION DETAIL
  https://phabricator.kde.org/D13864

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None"

2018-07-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In JavaScript `undefined` does not convert to empty string, so `undefined != 
""` is always `true`.
  The role isn't added to the `QStandardItemModel` for "None", so it is 
`undefined` (null `QVariant`) as far as QML is concerned.

TEST PLAN
  5.13
  "None" has the "no thumbnail available" icon now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13864

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart