D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled
This revision was automatically updated to reflect the committed changes. Closed by commit R110:2b5a4727ee34: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled (authored by kossebau). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13871?vs=38504=38566 REVISION DETAIL https://phabricator.kde.org/D13871 AFFECTED FILES autotests/testinprocess.cpp To: kossebau, dfaure, sebas, gladhorn Cc: gladhorn, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled
kossebau updated this revision to Diff 38504. kossebau added a comment. Complete the indentation Other sketched changes like splitting out into own test case methods not continued here, needs bigger work with more understanding of the tested stuff REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13871?vs=37117=38504 BRANCH makeTestSkipDBusTettsIfNotFound REVISION DETAIL https://phabricator.kde.org/D13871 AFFECTED FILES autotests/testinprocess.cpp To: kossebau, dfaure, sebas Cc: gladhorn, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled
gladhorn added a comment.
Looks good, please finish up cleanup/indentation and I'll accept.
INLINE COMMENTS
> testinprocess.cpp:142
> +if (m_backendServiceInstalled) {
> qDebug() << "TT xrandr out-of-process";
> // Load the xrandr backend out-of-process
Please indent.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D13871
To: kossebau, dfaure, sebas
Cc: gladhorn, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled
kossebau added a comment. Initial draft version of the patch for principal review. Blocks should be indented surely. Perhaps the test methods should be also separated each into in-orocess and out-of-process , so the out-of-process ones could get a QSKIP at the begin, for improved logging in the test result of the skipped test variants? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D13871 To: kossebau, dfaure, sebas Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled
kossebau created this revision. kossebau added reviewers: dfaure, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With the movement to support running unittests pre-installation and KDE CI having adapted to that for some build setups, this currently breaks tests which rely on subject-under-test D-Bus services being auto-started from D-Bus service files, given the D-Bus daemon does not see the uninstalled ones. One solution might be to catch that situation and do the start of the D-Bus service ourselves, but I failed to get this done quickly. So as intermediate solution, to at least have the in-process tests no longer being covered by the out-of-process ones failing, this patch will just skip the out-of-process tests if the D-Bus service could not be started. That follows the current behaviour of e.g. the KGlobalShortcutTest from KF5's kglobalaccel. TEST PLAN TestInProcess no longer fails if the org.kde.KScreen D-Bus service cannot be autostarted. REPOSITORY R110 KScreen Library BRANCH makeTestSkipDBusTettsIfNotFound REVISION DETAIL https://phabricator.kde.org/D13871 AFFECTED FILES autotests/testinprocess.cpp To: kossebau, dfaure, sebas Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
