D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-31 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0ec3f76810b7: [AppStream Runner] Also search when there 
were errors during Pool::load (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14807?vs=40160=40770

REVISION DETAIL
  https://phabricator.kde.org/D14807

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, #frameworks, apol
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-31 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  whatever.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, #frameworks, apol
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-31 Thread Stefan Brüns 
bruns added a comment.


  As I said, that violates 
https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets and 
I prefer to keep these apart.
  
  This one fixes the behaviour, and has a separate bug report.
  
  The other ones change logging and are quite independent.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, #frameworks
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-31 Thread Aleix Pol Gonzalez 
apol added a comment.


  Ugh, like I said, can you please squash them into a commit?
  They are good changes in general.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, #frameworks
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-29 Thread Stefan Brüns 
bruns added a comment.


  Anyone at home? Not answering a simple question is rude, at best.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol, #frameworks
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-25 Thread Stefan Brüns 
bruns added a comment.


  @apol - any reason you are holding this back?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-21 Thread Stefan Brüns 
bruns updated this revision to Diff 40160.
bruns edited the test plan for this revision.
bruns added a comment.


  Remove from patch stack, apply first

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14807?vs=39637=40160

REVISION DETAIL
  https://phabricator.kde.org/D14807

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Stefan Brüns 
bruns added a comment.


  Citing from 
https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
  
  > OTOH, commits should be preferably "atomic" - not splittable. That means 
that every bugfix, feature, refactoring or reformatting should go into an own 
commit. This, too, improves the readability of the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Stefan Brüns 
bruns added a comment.


  In D14807#309460 , @apol wrote:
  
  > This is outright weird, please send just one patch with the feature and the 
logging and without the wrong lines.
  
  
  Which wrong lines?
  
  Why should I squash the commits? Each one:
  
  - compiles **and** works on its own
  - addresses a slightly different issue

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Aleix Pol Gonzalez 
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Please squash all changes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Aleix Pol Gonzalez 
apol added a comment.


  This is outright weird, please send just one patch with the feature and the 
logging and without the wrong lines.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-13 Thread Stefan Brüns 
bruns created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The return code of the Pool::load() method is somewhat misleading, as it
  returns true only if there were no errors at all, but may have initialized
  the pool with meaningful data even when returning false.

TEST PLAN
  #plasma 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve_verbosity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14807

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart