D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

2018-08-23 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eac5d2e40e1e: [MPRIS Data Engine] Avoid blocking calls in 
media shortcuts handling (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14970?vs=40129=40305

REVISION DETAIL
  https://phabricator.kde.org/D14970

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playercontrol.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

2018-08-21 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  All the information we need (player capabilities and playback status) is 
already present and managed by the `PlayerContainer`
  
  BUG: 397685
  FIXED-IN: 5.13.5

TEST PLAN
  Started VLC, ran `killall -SIGSTOP vlc`, pressed "Pause" on my keyboard, 
plasma would no longer freeze
  Back, forward, pause keys still work fine

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14970

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playercontrol.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart