D15875: [Media Controller] Disallow seeking beyond end of track

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  In D15875#334752 , @anthonyfieroni 
wrote:
  
  > 1s file is a corner case as well as 0, cause you have always 2 positions - 
start and stop.
  
  
  The slider's value is floating point, so you also have the (theoretically) 
infinite positions in between.
  
  > In 0/1s these 2 steps just match, if you are right 0 isn't valid in 0s 
length file, does it?
  
  A file with 0s length can't be seeked.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15875

To: broulik, #plasma, fvogt
Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D15875: [Media Controller] Disallow seeking beyond end of track

[Anthony Fieroni]

anthonyfieroni added a comment.


  1s file is a corner case as well as 0, cause you have always 2 positions - 
start and stop. In 0/1s these 2 steps just match, if you are write 0 isn't 
valid in 0s length file, does it?
  +1 for the patch from me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15875

To: broulik, #plasma, fvogt
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15875: [Media Controller] Disallow seeking beyond end of track

[Fabian Vogt]

fvogt added a comment.


  I'm not sure whether that's correct - a file with a duration of 1s still has 
a range of 1s.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15875

To: broulik, #plasma, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15875: [Media Controller] Disallow seeking beyond end of track

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A track of 60 seconds length has the valid positions `[0,59]` so subtract `-1`

TEST PLAN
  No longer issues `SetPosition` command with invalid bounds

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15875

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: broulik, #plasma, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart