D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml 
(authored by asturmlechner).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43221=43247

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner 
asturmlechner added a comment.


  In D16073#340107 , @alexeymin 
wrote:
  
  > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: 
fatal error: QDomDocument: No such file or directory` then fine...
  
  
  Yes, it was exactly that: https://bugs.gentoo.org/668166

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Alexey Min 
alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  
https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
  Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus 
probably depends on QtXml and QtDbus was removed)
  If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal 
error: QDomDocument: No such file or directory` then fine...

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner 
asturmlechner updated this revision to Diff 43221.
asturmlechner added a comment.


  Only pull in Qt5Xml if OpenConnect is requested.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43220=43221

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner 
asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  QDomDocument is imported from vpn/openconnect/openconnectauth.cpp

TEST PLAN
  Build succeeds now.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  CMakeLists.txt
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart