D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43959.
ngraham added a comment.


  - Also do the Location page
  - Use `Spacer` items instead of hacks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43899=43959

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a comment.


  Instead of ghetto DIY spacers, maybe we can use purpose-built vertical 
spacers: D16330: Add a vertical spacer item 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43899.
ngraham added a comment.


  Make the ghetto spacers invisible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43835=43899

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Andres Betts]

abetts added a comment.


  In D16241#345082 , @ngraham wrote:
  
  > Kirigami FormLayout is a really nice control to work with. I'm a big fan. 
This port was easy peasy and I can't wait to do more of these!
  >
  > The double `Kirigami.Separator` items are to approximate what's wanted for 
https://bugs.kde.org/show_bug.cgi?id=399959, but this is probably an incorrect 
usage of them as-is. Would like to get @mart's opinion on the best way to add 
some whitespace to a Kirigami FormLayout.
  
  
  Love it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  Kirigami FormLayout is a really nice control to work with. I'm a big fan. 
This port was easy peasy and I can't wait to do more of these!
  
  The double `Kirigami.Separator` items are to approximate what's wanted for 
https://bugs.kde.org/show_bug.cgi?id=399959, but this is probably an incorrect 
usage of them as-is. Would like to get @mart's opinion on the best way to add 
some whitespace to a Kirigami FormLayout.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43835.
ngraham added a comment.


  No more ugly hacks: port the whole thing to use a Kirigami FormLayout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43758=43835

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43758.
ngraham added a comment.


  Fix the Text Lines label and spinbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43712=43758

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Oops, found a few visual glitches. Will fix today.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Thomas Surrel]

thsurrel added a comment.


  That looks much better!
  Any reason why the "Text lines" parameter in the Icon panel is not aligned 
with the rest of the form ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a comment.


  Note: I know the `width: 500` is a horrible hack that is certainly the wrong 
way to do this, but I couldn't figure out how else to get the Labels' width to 
be long enough so that `Layout.alignment: Qt.AlignRight` worked. 
`Layout.fillWidth: true` had no effect. I look forward to learning the correct 
way to handle this situation. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43712.
ngraham added a comment.


  Improve another string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43710=43712

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a comment.


  Note: I know the `width: 500` is a horrible hack that is certainly the wrong 
way to do this, but I couldn't figure out how else to get the Labels' width to 
be long enough so that `Layout.alignment: Qt.AlignRight` worked. 
`Layout.fillWidth: true` had no effect. I look forward to learning the correct 
way to handle this situation. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Improve the layout and formatting of the Icons page to follow 
https://hig.kde.org/patterns/content/form.html

TEST PLAN
  Desktop, before:
  
  After:
  
  Panel widget, before:
  
  After:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart