D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

2018-11-14 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking 
FetchSqlite instances (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16410?vs=44170=45490

REVISION DETAIL
  https://phabricator.kde.org/D16410

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #frameworks, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

2018-10-24 Thread Stefan Brüns
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The favicon and places instances are created in the prepare() call,
  leaking the instance from the last invocation. Delete the old
  instance in teardown().
  
  See also T9626 .

TEST PLAN
  run several queries in krunner
  -> instances are no longer leaked

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16410

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart