D16842: [clipboard] Limit length of clipboard text item visualisation
This revision was automatically updated to reflect the committed changes. anthonyfieroni marked an inline comment as done. Closed by commit R120:d53622d7d9e0: [clipboard] Limit length of clipboard text item visualisation (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16842?vs=45367=45395#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16842?vs=45367=45395 REVISION DETAIL https://phabricator.kde.org/D16842 AFFECTED FILES applets/clipboard/contents/ui/TextItemDelegate.qml To: anthonyfieroni, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16842: [clipboard] Limit length of clipboard text item visualisation
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TextItemDelegate.qml:33 > > -var text = DisplayRole > +var text = DisplayRole.slice(0, 64) > I think 100 is better since it can wrap to up to three lines, fine otherwise REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16842 To: anthonyfieroni, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16842: [clipboard] Limit length of clipboard text item visualisation
anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Applying regex to long text item (> 5000 symbols) is extremely slow and memory consuming. TEST PLAN Make a config over 16 records in Clipboard, copy some json string or whatever you have as long texts > 5000 symbols. I hat slow plasmashell, high cpu usage, slow running and over 700 MB of RAM. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16842 AFFECTED FILES applets/clipboard/contents/ui/TextItemDelegate.qml To: anthonyfieroni, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
