D16861: Improve contrast for Breeze Snow and the Breeze crosshair

2018-11-13 Thread Nathaniel Graham
ngraham added a comment.


  Imagine that, reading the README. :) If manual work is required for each 
image, that seems like all the more reason to only include the two changed ones 
in the diff.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16861: Improve contrast for Breeze Snow and the Breeze crosshair

2018-11-13 Thread Noah Davis
ndavis planned changes to this revision.
ndavis added a comment.


  Hmm some of the cursors seem blurrier than they used to be and I have no idea 
why.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16861: Improve contrast for Breeze Snow and the Breeze crosshair

2018-11-13 Thread Nathaniel Graham
ngraham added a comment.


  FWIW the actual crosshair cursors seem better to me now, especially the 
Breeze snow one. You could maybe just take the changed files for the crosshairs 
and make a new diff with just them if you can't figure out the other issue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16861: Improve contrast for Breeze Snow and the Breeze crosshair

2018-11-13 Thread Noah Davis
ndavis added a comment.


  I think I found the reason why the prebuilt cursor themes are included in the 
repo in the README:
  
  > No trimming will have been done to the cursors, and X11 *may* give you 
split-second glitches when switching cursors making them appear to 'jump' for 
an instant. To remedy this, you will need to open any auto-generated in gimp 
and re-export when with the “trim whitespace” option checked. I do not beleive 
it impacts all versions of X, or Wayland.
  
  
  
  > You will need the “X11 Mouse Cursor (XMC)” plugin for GIMP installed to 
trim the cursors if you choose to do so.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16861: Improve contrast for Breeze Snow and the Breeze crosshair

2018-11-13 Thread Noah Davis
ndavis added a comment.


  In D16861#359170 , @ngraham wrote:
  
  > So is there a script that regenerates all the X11 cursor files from the SVG 
whenever it's changed or something? Because I'm willing to bet you didn't 
change all 654 cursors...
  
  
  There's a `build.sh` file that uses `xcursorgen`. I used that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart