D16988: [Kickoff] Make the visible search field unfocused by default

[David Edmundson]

davidedmundson added a comment.


  > Seeing as this causes the latest plasmashell to lock up
  
  Can you expand on this? What locks up?
  
  I had a bug report this week of a guy who had kickoff locking up on pressing 
tab

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty abandoned this revision.
rooty added a comment.


  Seeing as this causes the latest plasmashell to lock up and I was never too 
enthusiastic about the change either, I'm going to close this, sorry guys.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#367971 , @filipf wrote:
  
  > In D16988#367970 , @rooty wrote:
  >
  > > Suffice it to say, you can't use any of the other patches (except the 
font size / label change) without this one.
  >
  >
  > Separating this doesn't make sense either because there's no need to change 
"Search..." to "Type to search..." if the field will remain focused as it is 
now.
  
  
  good point. so they're entirely dependent.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Filip Fila]

filipf added a comment.


  In D16988#367970 , @rooty wrote:
  
  > Suffice it to say, you can't use any of the other patches (except the font 
size / label change) without this one.
  
  
  Separating this doesn't make sense either because there's no need to change 
"Search..." to "Type to search..." if the field will remain focused as it is 
now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#366146 , @ngraham wrote:
  
  > D17020 , D17022 
, and D17023 
 still include duplicated changes from this 
patch.
  >
  > The idea was to make all of your Kickoff patches independent of each other, 
or at least to thin out the dependency tree so that all the patches depend on a 
single ancestor patch that only has uncontroversial refactoring changes. Right 
now the dependency on this one means that all of your other 
much-less-controversial changes are gated on getting acceptance for making the 
search field visually unfocused by default.
  >
  > Am I making any sense?
  
  
  No. What you're saying makes a kind of sense until you actually think about 
it - while it's possible to change D17023  
to make it more discrete (it's a font size and label change, basically three 
lines of code), even that makes little sense in the face of a focused search 
field that would be present without all the other patches. It's not possible to 
make D17022  or D17020 
 (//**re**//-enable hover) independent 
because they //quite literally// depend on an unfocused search field and are 
bug fixes for issues that this here diff introduces. So it makes //very little 
if any sense// to make them independent (the current Kickoff doesn't have these 
bugs).
  
  Suffice it to say, you can't use any of the other patches (except the font 
size / label change) without this one.
  
  P.S. If you want to reject the patch based on controversy, that's fine with 
me. I don't care much about the focus anyway tbh

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Nathaniel Graham]

ngraham added a comment.


  D17020 , D17022 
, and D17023 
 still include duplicated changes from this 
patch.
  
  The idea was to make all of your Kickoff patches independent of each other, 
or at least to thin out the dependency tree so that all the patches depend on a 
single ancestor patch that only has uncontroversial refactoring changes. Right 
now the dependency on this one means that all of your other 
much-less-controversial changes are gated on getting acceptance for making the 
search field visually unfocused by default.
  
  Am I making any sense?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Marco Martin]

mart added a comment.


  In D16988#361739 , @filipf wrote:
  
  > It also conceptually makes more sense to have the search field unfocused 
because searching is not necessarily the main activity done within Kickoff, so 
why have it in focus all the time?
  
  
  is important to have the workflow open the menu + just start typing intact to 
put search at the center of the ui

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  this breaks the workflow open menu and just start typing

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson, mart
Cc: mart, abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45820.
rooty added a comment.


  - [Kickoff] Make search field unfocused but visible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45757=45820

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  Thanks!
  
  Ironically, I do like it focused too 藍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Nathaniel Graham]

ngraham added a comment.


  Cool, I'm looking forward to most of these changes. And you may yet convince 
me on the visually-unfocused-search-field-by-default thing. :)
  
  Here's the documentation for creating a dependency chain of patches: 
https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > You can do this as you see fit. I would recommend though in this case to 
make a patch series where patches depend on each other since otherwise it can 
become difficult to keep all the independent patches consistent with each other.
  
  Excellent.
  
  > I believe in you! :) If you need quick help come join the Plasma IRC 
channel.
  
  Thanks! :D I just have to figure out how IRC works now. And I thought //arc// 
was a challenge 藍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  In D16988#362323 , @rooty wrote:
  
  > Clipboard works like this but the coding is beyond my abilities. Krunner 
does this too except it opens up with the search field in focus. This Kickoff 
patched version can't do that, and I've yet to figure out how to make it be 
able to.
  
  
  I believe in you! :) If you need quick help come join the Plasma IRC channel.
  
  > It's not necessary to do so in Kicker. You can just keep on typing.
  
  I know it's not necessary. I meant that it should not be allowed. My argument 
is there is no purpose/advantage to that if you can just continue typing from 
every focused item. All it does is making it one more item to cycle through 
when moving up/down through the search results.
  
  > Patches that would patch this patch or patches that would each patch master 
separately?
  
  You can do this as you see fit. I would recommend though in this case to make 
a patch series where patches depend on each other since otherwise it can become 
difficult to keep all the independent patches consistent with each other.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#362281 , @romangg wrote:
  
  > I like all the changes, but they should go into separate patches:
  
  
  Patches that would patch this patch or patches that would each patch master 
separately?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > Why does it make it easy?
  
  Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I 
think my point was that it works regardless of the focus being drawn away from 
it?)
  
  > - By default search field looks unactivated but has focus. Arrow up/down 
sets focus to the item selected, but typing to start a search is still possible.
  
  Clipboard works like this but the coding is beyond my abilities. Krunner does 
this too except it opens up with the search field in focus. This Kickoff 
patched version can't do that, and I've yet to figure out how to make it be 
able to.
  
  > - One does not need to go back to the search field with arrow keys to 
add/remove characters (and also should not be able to do that like in Kicker).
  
  It's not necessary to do so in Kicker. You can just keep on typing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  In D16988#362160 , @rooty wrote:
  
  > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  
  
  Why does it make it easy?
  
  > (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  >  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  
  Every applet does it differently. Great.
  
  I would propose:
  
  - By default search field looks unactivated but has focus. Arrow up/down sets 
focus to the item selected, but typing to start a search is still possible.
  - While typing input field and current top item look activated, but focus 
shall not lie on the input field but on the item which would get started when 
Enter is pressed (this item could change while continuing to type).
  - When moving in the search results with arrow keys up/down the search field 
stays activated (but still the focus lies on the currently selected item).
  - One does not need to go back to the search field with arrow keys to 
add/remove characters (and also should not be able to do that like in Kicker).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  I like all the changes, but they should go into separate patches:
  
  > (1) Keeps the search field visible by default but leaves it unfocused until 
triggered by the keyboard
  
  Patch 1
  
  > (2) Enables the tab key to select/focus the search field just like any 
other key
  
  Patch 2
  
  > (3) Enables the escape key to collapse Kickoff when pressed from within an 
empty focused search field that was activated by either a mouse click
  >  or the tab key (a bug in the previous version of Kickoff evident due to an 
unfocused search area)
  >  (4) Enables the escape key to return the user to the tabbed view in 
Kickoff when pressed from within a non-empty search field
  
  Patch 3
  
  > (5) Changes the label 'Search...' to 'Type to search...' so that the user 
is made aware that they can, in fact, type to search
  >  (6) Maintains the ability to hover over the user's name to show more 
information about the system
  >  (7) Lowers the font size of the username to make it fit in better with the 
search field and user picture/avatar
  
  Patch 4
  
  You could use this diff here for patch 1 and split the other changes into 
dependent diffs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#362206 , @chempfling 
wrote:
  
  > In D16988#362160 , @rooty wrote:
  >
  > > Okay so from what I can tell:
  > >
  > > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  > >  (2) Krunner becomes unfocused if you use the arrow keys, **but not if 
you hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  > >  (3) Kickoff (the old, the master and this patch) seems to leave the 
search field focused at all times while you go through the results, and it's 
possible to add more characters to the search like in (1) and (2).
  > >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  > >
  > > Any thoughts on how to reconcile all these differences? It might take 
some doing 
  >
  >
  > Howdy,
  >
  > just for clearification :). With focus and unfocuse we talk about "focus: 
true", not only an highlighting effect?
  
  
  Yup - not just a cosmetic effect

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Christian Hempfling]

chempfling added a comment.


  In D16988#362160 , @rooty wrote:
  
  > Okay so from what I can tell:
  >
  > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  >  (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  >  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  >
  > Any thoughts on how to reconcile all these differences? It might take some 
doing 
  
  
  Howdy,
  
  just for clearification :). With focus and unfocuse we talk about "focus: 
true", not only an highlighting effect?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  Okay so from what I can tell:
  
  (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  (4) Clipboard behaves pretty much like this patch except //pressing the Esc 
key doesn't make it unfocused again//.
  
  Any thoughts on how to reconcile all these differences? It might take some 
doing 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Frederik Gladhorn]

gladhorn added a comment.


  In D16988#362104 , @rooty wrote:
  
  > @gladhorn More food for thought by the way: in this patch (and the master) 
the search field is focused while searching and while navigating the search 
results - it still accepts input even though you've technically navigated away 
from it. Should this functionality be kept (regardless of if the search field 
remains visibly focused or not), or should we prevent the user from typing into 
the search field while the focus is on the search results?
  >
  > I think it's a good idea to let the user type to search from wherever they 
may be in Kickoff, but to draw the focus away from the search field (like 
Kicker).
  
  
  Yes, I want to be able to type, no matter where, but the search result should 
get the focus in my opinion. We don't want to lose that functionality, it's 
about knowing what the currently most relevant item is, just like a sighted 
user would see the top list item. Then if the arrow keys for example work to go 
to the next search result, just like you'd glance down, then that's perfect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  @gladhorn More food for though, by the way: in this patch (and the master) 
the search field is focused while searching and while navigating the search 
results - it still accepts input even though you've technically navigated away 
from it. Should this functionality be kept (regardless of if the search field 
remains visibly focused or not), or should we prevent the user from typing into 
the search field while the focus is on the search results?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > Actually this sounds like it might help our cause. Especially when the 
search bar can be tabbed into, that's really nice. The problem is that we would 
like to focus to be on the selected item, such as the one that gets launched 
when pressing enter. The search should not have the focus unless the user type. 
I didn't look at the code change at all, but from the description it may just 
be a step forward.
  
  This did occur to me too, and it's a great idea, I just haven't figured out 
how to implement it yet haha

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Frederik Gladhorn]

gladhorn added a comment.


  In D16988#361980 , @ngraham wrote:
  
  > There are a lot of good changes in here, like those keyboard navigation 
improvements! And I appreciate all the work that clearly went into this. 
However, the problem with huge patches like this is that if we like some but 
not all of it, you end up needing to re-work a lot of the patch. That's 
generally why we prefer "atomic" changes with one change per patch/commit. It 
makes that kind of thing way saner.
  >
  > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have 
been working hard to push on accessibility, and one thing I've learned in the 
past week weeks is how important focus is. Making sure that the active element 
both has and looks like it has focus is critical to making sure  the UI is 
accessible for screen readers. As such, we need to keep it visually focused by 
default when it opens.
  
  
  Actually this sounds like it might help our cause. Especially when the search 
bar can be tabbed into, that's really nice. The problem is that we would like 
to focus to be on the selected item, such as the one that gets launched when 
pressing enter. The search should not have the focus unless the user type. I 
didn't look at the code change at all, but from the description it may just be 
a step forward.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > Right, I agree. In fact, that's how Kicker does it: the search field is 
focused by default, but if you mouse over a list item, then focus visually 
moves to the list. I'm supportive of doing that sort of thing here. Then the 
Kicker and Kickoff search fields would even be consistent with one another, 
which would be a nice benefit.
  
  Not bad. I'd have to rework this Header.qml to make it more like Kicker 
though. But that's only if everyone's really sure they don't want the unfocused 
search field.
  
  By the way, should I separate the font and hover changes into two separate 
patches or just one medium-sized one? :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have 
been working hard to push on accessibility, and one thing I've learned in the 
past week weeks is how important focus is. Making sure that the active element 
both has and looks like it has focus is critical to making sure  the UI is 
accessible for screen readers. As such, we need to keep it visually focused by 
default when it opens.
  
  I respectfully disagree. While this is a very valid point (and I don't 
dislike the already focused search field), the verb type in the imperative mood 
is the most efficient way to inform the user that they can search. Furthermore, 
the UI seeming accessible if focused is more of an intuitive leap. Spotlight, 
for instance, does this by means of a magnifying glass, and it moves onto the 
focused search results by default, but it doesn't focus the search field - 
there is //simply little if any benefit// in keeping the actual search field 
focused (it's too obvious). That's why I was tinkering with the idea of 
removing the focus altogether (but I do like the blue).
  
  //In short, there is simply no need to have the search field visually focused 
by default when it opens, not in Kicker (the text would need to be changed to 
Type to search...), not in Krunner and not even in Clipboard (where this has 
already long been implemented). 
  //
  
  > One more note: while compatibility with 3rd-party themes is a laudable 
goal, it can never be a primary one, and it can't dictate design 
considerations. 3rd-party themes are a moving target and chasing them is 
futile, so  "this change makes it look better with 3rd-party themes" can never 
be a selling point. It has to be better for Breeze first and foremost. If the 
change also improves the look for 3rd-party themes, all the better, but that 
can't be the primary consideration.
  
  Futile? I beg to differ. While not primary, it should still be paramount. The 
fact that it makes it look better for third party themes should be a major 
concern for KDE, because KDE is touted as endlessly customizable (and this is 
one of the main reasons a lot of people prefer KDE to GNOME... or Windows/Mac, 
for that matter).
  
  > So I'd like to see the font size changes go into one patch, the keyboard 
navigation improvements go into a second, and the search field placeholder text 
change in a third one. I think those are fairly non-controversial.
  
  While in principle I do agree, this is impossible to accomplish here without 
making a decision about whether the search field is unfocused or not. Splitting 
up the patch means that the keyboard improvements go down the drain //(Esc is 
used to escape no matter what (this works already) and there's no need to use 
Tab to select the search field (it's already in focus)//. The only thing that's 
salvageable is the font size change and the change in the text within the field 
(and the hover font change). The hover changes themselves (not the font), the 
keyboard improvements etc. are simply too intertwined with the unfocused search 
field and the way the states are defined. You'd have to rewrite the unfocused 
portions, but there's essentially no point in doing so seeing as you'll never 
be using those keyboard improvements in the first place if it's already focused.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Nathaniel Graham]

ngraham added a comment.


  In D16988#362025 , @filipf wrote:
  
  > Hmm but it doesn't even need to be primarily argumented as a visual 
improvement. Can't we approach the focused/unfocused matters contextually? If 
I'm using Kickoff mostly to click on my favorites and use the leave actions, 
why should the search field be glowing and be at 100% opacity all the time?
  
  
  Right, I agree. In fact, that's how Kicker does it: the search field is 
focused by default, but if you mouse over a list item, then focus visually 
moves to the list. I'm supportive of doing that sort of thing here. Then the 
Kicker and Kickoff search fields would even be consistent with one another, 
which would be a nice benefit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Filip Fila]

filipf added a comment.


  In D16988#361980 , @ngraham wrote:
  
  > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have 
been working hard to push on accessibility, and one thing I've learned in the 
past week weeks is how important focus is. Making sure that the active element 
both has and looks like it has focus is critical to making sure  the UI is 
accessible for screen readers. As such, we need to keep it visually focused by 
default when it opens.
  >
  > I would be open to making the search field behave like it does in Kicker: 
visually focused by default, but then focus shifts to list items when they're 
active (but you can still type-to-search anywhere).
  >
  > One more note: while compatibility with 3rd-party themes is a laudable 
goal, it can never be a primary one, and it can't dictate design 
considerations. 3rd-party themes are a moving target and chasing them is 
futile, so  "this change makes it look better with 3rd-party themes" can never 
be a selling point. It has to be better for Breeze first and foremost. If the 
change also improves the look for 3rd-party themes, all the better, but that 
can't be the primary consideration.
  
  
  Hmm but it doesn't even need to be primarily argumented as a visual 
improvement. Can't we approach the focused/unfocused matters contextually? If 
I'm using Kickoff mostly to click on my favorites and use the leave actions, 
why should the search field be glowing and be at 100% opacity all the time?
  
  For comparison's sake and looking at our major competitors, there is no such 
thing in Windows - there's even no search field in the menu and the Cortana tab 
on the panel which can act as a replacement isn't focused until you interact 
with it. In GNOME, which is even more incentivized to keep the search field 
focused, that doesn't happen either and the field looks subtle. From what I'm 
seeing, in macOS the Launchpad's search bar is even subtler than in GNOME and 
sans a blinking cursor that can be activated, there isn't even such a thing as 
a focused state. I also see that Spotlight search, which is actually something 
like KRunner (so something made solely for searching) is pretty subtle looking 
and also doesn't have a focus state. And I notice they've got search fields 
everywhere and none of them are focused unless interacted with. The Deepin 
search bar likewise blends in seamlessly into the menu and doesn't seem to have 
a focused state either. Budgie only has an underline of sorts as its one and 
only state. The Cinnamon menu has only one state and it's subtle looking. In 
short, seems like a lot of desktop environments make do just fine without 
making the search bar stick out.
  
  Taking that into account, plus the fact that we didn't even have a search 
field for 4 years — and that this hasn't been complained about //that 
//unanimously and vocally — is it really that imperative to keep it focused?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added subscribers: chempfling, gladhorn.
ngraham added a comment.
This revision now requires changes to proceed.


  There are a lot of good changes in here, like those keyboard navigation 
improvements! And I appreciate all the work that clearly went into this. 
However, the problem with huge patches like this is that if we like some but 
not all of it, you end up needing to re-work a lot of the patch. That's 
generally why we prefer "atomic" changes with one change per patch/commit. It 
makes that kind of thing way saner.
  
  And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have 
been working hard to push on accessibility, and one thing I've learned in the 
past week weeks is how important focus is. Making sure that the active element 
both has and looks like it has focus is critical to making sure  the UI is 
accessible for screen readers. As such, we need to keep it visually focused by 
default when it opens.
  
  I would be open to making the search field behave like it does in Kicker: 
visually focused by default, but then focus shifts to list items when they're 
active (but you can still type-to-search anywhere).
  
  One more note: while compatibility with 3rd-party themes is a laudable goal, 
it can never be a primary one, and it can't dictate design considerations. 
3rd-party themes are a moving target and chasing them is futile, so  "this 
change makes it look better with 3rd-party themes" can never be a selling 
point. It has to be better for Breeze first and foremost. If the change also 
improves the look for 3rd-party themes, all the better, but that can't be the 
primary consideration.
  
  So I'd like to see the font size changes go into one patch, the keyboard 
navigation improvements go into a second, and the search field placeholder text 
change in a third one. I think those are fairly non-controversial.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45757.
rooty added a comment.


  - Trim unnecessary code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45753=45757

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Filip Fila]

filipf added a comment.


  I cannot comment on the technical side of things (noob), and am perhaps a 
little biased since Root and I are best friends who have been working (mostly 
him) on Kickoff this weekend as our first real contribution to KDE, however... 
this change can really do wonders for helping the search bar blend in 
throughout various themes and should be the final nail in the coffin of that 
debate. It helps a lot with transparent themes:
  
  F6431072: Screenshot_20181118_211024.png 

  
  F6431071: Screenshot_20181118_211058.png 

  (here depicted: the Opal desktop theme)
  
  It also conceptually makes more sense to have the search field unfocused 
because searching is not necessarily the main activity done within Kickoff, so 
why have it in focus all the time?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45753.
rooty added a comment.


  - Fix broken states and return ability to hover

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45751=45753

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45751.
rooty added a comment.


  - Tidy up some more

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45750=45751

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45750.
rooty added a comment.


  - Remove unnecessary states, tidy things up

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45747=45750

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  Changes: applets/kickoff/package/contents/ui/Header.qml
  
  This patch:
  (1) Keeps the search field visible by default but leaves it unfocused until 
triggered by the keyboard
  (2) Enables the tab key to select/focus the search field just like any other 
key
  (3) Enables the escape key to collapse Kickoff when pressed from within an 
empty focused search field that was activated by either a mouse click
  or the tab key (a bug in the previous version of Kickoff evident due to an 
unfocused search area)
  (4) Enables the escape key to return the user to the tabbed view in Kickoff 
when pressed from within a non-empty search field
  (5) Changes the label 'Search...' to 'Type to search...' so that the user is 
made aware that they can, in fact, type to search
  (6) Maintains the ability to hover over the user's name to show more 
information about the system
  (7) Lowers the font size of the username to make it fit in better with the 
search field and user picture/avatar

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart