D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:50c69c2c069f: Drop tab-based UI for the about page 
(authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46479=46480

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/qml/AboutPage.qml
  discover/qml/ApplicationPage.qml
  discover/qml/LinkButton.qml
  discover/qml/UrlButton.qml
  discover/resources.qrc
  libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46479.
apol added a comment.


  Adopt the AboutPage upstream in Kirigami

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46390=46479

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/qml/AboutPage.qml
  discover/qml/ApplicationPage.qml
  discover/qml/LinkButton.qml
  discover/qml/UrlButton.qml
  discover/resources.qrc
  libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  Yes, yes, on it...

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Kai Uwe Broulik]

broulik added a comment.


  Wouldn't it make sense to provide an `AboutPage` in Kirigami 
(KF5::kirigami-whatever-that-can-be-tier-2 :D) like kxmlgui has it, for use in 
e.g. Itinerary and what not?

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Lovin' it - i also like how sort of... well, how little code there really is 
here, QML done absolutely the right way, only the presentation and that's it, 
nifty :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46390.
apol added a comment.


  Move report action back to the contextual actions

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46328=46390

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/qml/AboutPage.qml

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I did prefer it in the toolbar. I think that actually makes it more 
prominent, not less. If we are worried about people sending the developers too 
many emails, we could de-emphasize the email address. The current UI just uses 
a tiny button which seems adequately obfuscatory :) Or maybe the developer's 
name could be a mailto link instead of having the address itself visible in 
plain view?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17177#366890 , @ngraham wrote:
  
  > Looks fantastic!
  >
  > Could we put the bug report button on the toolbar, maybe? It looks a bit 
odd just sitting in the content view like that.
  
  
  It was on the last version. I could easily see people going to send 
developers an e-mail instead of reporting the issue properly, that's why I put 
it there.
  Did you like it better up there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Also, and I don't know if this is in Discover or the proposed new page, but 
the item in Discover's sidebar should match the page title and say "About", not 
"Help."

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Looks fantastic!
  
  Could we put the bug report button on the toolbar, maybe? It looks a bit odd 
just sitting in the content view like that.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  F6443951: discover-about4.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46328.
apol added a comment.


  Remove the bug reporting weirdness

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46324=46328

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/qml/AboutPage.qml

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I think a "Report a bug!" button would be fine.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17177#366883 , @ngraham wrote:
  
  > Well then Discover is setting the wrong information :)
  >
  > Can we have an updated screenshot if the last code change resulted in any 
visual changes?
  
  
  Ah you're right. Let's try putting the button there anyway?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Well then Discover is setting the wrong information :)
  
  Can we have an updated screenshot if the last code change resulted in any 
visual changes?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17177#366500 , @ngraham wrote:
  
  > Looks much better visually! But something about the bugDisplay looks wrong. 
Right now it's recommending that people send bugs via email.
  
  
  No it's not, it's recomending to go to bugs.kde.org or wherever the developer 
pointed at.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46324.
apol added a comment.


  Address Dan's concern

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46280=46324

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/qml/AboutPage.qml

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Ah yes, somehow i managed to miss the button @colomar mentions, which does 
the bug reporting linkage already. Removing the link in favour of just keeping 
that button seems a sensible option :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.


  It does seem that the bugAddress being an email address is a bit odd... The 
address given by KAboutData::bugAddress 

 can be either an email address, or a URL, though, so it might make sense to 
try and handle either case (something as simple as checking for :// in the 
string would probably work), to make the functionality here functionally 
equivalent to the qwidget dialogue.
  
  At the same time, though, given that Discover's /is/ an email address... 
would it perhaps make sense to at least add bugs.kde.org as a link? (or, some 
other way of adding a secondary link for reports... though that does seem to be 
veering somewhat outside the scope of this particular patch)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Thomas Pfeiffer]

colomar added a comment.


  Integrating it in one page is definitely an improvement!
  Some detailed comments (I am aware that those things  introduced with this 
layout change, they just become apparent now):
  
  1. "About" at the top of the page and "About Discover..." are redundant. I'd 
recommend just integrating the Copyright and license lines above the hline and 
removing the "About Discover..." heading
  2. "Libraries" -> "Libraries used" (might be a bit too long for a tab title 
but as a title on a page it's perfectly fine)
  3. I'd maybe remove the "Please use..." line above the authors because we 
have the "Report Bug..." button at the top anyway so it would be redundant. If 
you fear that users might miss the button up there, I'd opt for moving the 
button elsewhere rather than having two different places for bug reporting on 
the same page

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg
Cc: colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Nathaniel Graham]

ngraham added a comment.


  Looks much better visually! But something about the bugDisplay looks wrong. 
Right now it's recommending that people send bugs via email.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  F6442717: discover-scrollableabout.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Integrates better with Kirigami.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/qml/AboutPage.qml

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart