D17347: Translate color scheme names
broulik added a comment. It seems most codepaths assume the colorscheme names are never translated... `KColorSchemeManager` uses the `Qt::DisplayRole` for mapping. The `Qt::UserRole` contains the full path to the scheme but it never stores just the untranslated name. Affects Krita, Kate, etc, which lost my "Honeycomb" colorscheme now that it's called "Honigwabe". Setting it again works but changing languages causes the mapping to fail. (See, that's why I didn't put it in stable branches :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17347 To: broulik, #plasma, lueck, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17347: Translate color scheme names
broulik added a comment. > making strings translatable does not break the string freeze I know but changing the names (and as such the order of in the list) of themes that haven't been translated forever I think isn't ideal for a stable or LTS. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17347 To: broulik, #plasma, lueck, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17347: Translate color scheme names
lueck added a comment. @broulik thanks. this was commited to master, but should go into stable and lts. making strings translatable does not break the string freeze REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17347 To: broulik, #plasma, lueck, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17347: Translate color scheme names
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4087961586e4: Translate color scheme names (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17347?vs=46836=46838 REVISION DETAIL https://phabricator.kde.org/D17347 AFFECTED FILES kcms/colors/schemes/ExtraDesktop.sh To: broulik, #plasma, lueck, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17347: Translate color scheme names
broulik created this revision. broulik added reviewers: Plasma, lueck. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 401136 FIXED-IN: 5.15.0 TEST PLAN The KCM reads e.g. `Name[de]=Honigwabe` but we never extracted them. Dunno if that works but translators told me it would :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17347 AFFECTED FILES kcms/colors/schemes/ExtraDesktop.sh To: broulik, #plasma, lueck Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
