D17574: Remove period ( . ) character from the end

2018-12-14 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: abetts, GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, sebas, apol, 
mbohlender, mart

D17574: Remove period ( . ) character from the end

2018-12-14 Thread Shubham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:998d1a02c670: Remove period ( . ) character from the end 
(authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17574?vs=47551=47563

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17574: Remove period ( . ) character from the end

2018-12-14 Thread Shubham 
shubham added a comment.


  my battery drained in "After" image even though it was charging : )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17574: Remove period ( . ) character from the end

2018-12-14 Thread Björn Feber 
GB_2 added a comment.


  The two images need to be swapped.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17574: Remove period ( . ) character from the end

2018-12-14 Thread Shubham 
shubham created this revision.
shubham added reviewers: Plasma, VDG.
shubham added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Before:
  F6476200: 1.png 
  
  After:
  F6476201: 2.png 

TEST PLAN
  Hover over battery monitor in system tray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg
Cc: plasma-devel, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart