D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2019-01-14 Thread Oleg Solovyov 
McPain added a comment.


  In D17689#391265 , @hein wrote:
  
  > Here's my take: https://phabricator.kde.org/D18182
  
  
  is this intentional you mentioned *this* review, not 
https://phabricator.kde.org/D17707?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2019-01-11 Thread Eike Hein 
hein added a comment.


  Here's my take: https://phabricator.kde.org/D18182

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2019-01-11 Thread Eike Hein 
hein added a comment.


  Thanks for the ping, it worked :)
  
  I'm looking into this today. I won't be able to accept this patch as-is, 
because it's working around the real problem. But it definitely helps in 
finding it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2019-01-10 Thread Oleg Solovyov 
McPain added a comment.


  In D17689#379900 , @hein wrote:
  
  > Cool, thanks for the update. I'm a bit flooded before the Christmas 
holidays, but I'll try to make sense of this in early 2019.
  
  
  ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2018-12-20 Thread Eike Hein 
hein added a comment.


  Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, 
but I'll try to make sense of this in early 2019.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

2018-12-19 Thread Eike Hein 
hein added a comment.


  Can you provide a description for this patch? What does it fix, why does it 
fix it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart