D17703: Fix KIOClient non-interactive mode handling renamed prompts
This revision was automatically updated to reflect the committed changes. Closed by commit R126:36a59ad77f5e: Fix KIOClient non-interactive mode handling renamed prompts (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17703?vs=47872&id=47920 REVISION DETAIL https://phabricator.kde.org/D17703 AFFECTED FILES kioclient/kioclient.cpp To: davidedmundson, #plasma, dfaure Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17703: Fix KIOClient non-interactive mode handling renamed prompts
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY In the kdelibs to KF5 transition a factory class was adding for loading rename prompts to make KIO gui-less. In jobs "if (isInteractive)" was changed everywhere into "if (uiDelegateExtension)". The former was false if we called KJob::setUiDelegate(nullptr). The latter is only false if the calling code explicitly calls the new KIO::Job::setUiDelegateExtension(nullptr) as well. This left kioclient5 in the very weird state of non-interactive mode still having rename dialogs but not error messages. Now non-interactive mode will simply error if it hits a conflict and stop. TEST PLAN Copied a conflict REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D17703 AFFECTED FILES kioclient/kioclient.cpp To: davidedmundson, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
