D17752: Remove full representation of analog clock

[Shubham]

shubham abandoned this revision.
shubham added a comment.


  Abandon in favor of above discussion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17752: Remove full representation of analog clock

[Marco Martin]

mart added a comment.


  In D17752#388166 , @abetts wrote:
  
  > I think part of the reason why this seems too big also if because it 
doesn't do much more than tell you what day it is. If it was able to integrate 
with a calendar application, it could show appointments. Something like this:
  >
  > https://goo.gl/images/rwgUw9
  
  
  the popup of the digital clock does that, what's the actual problem is that 
the analog and digital clocks aren't on par with features

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17752: Remove full representation of analog clock

[Andres Betts]

abetts added a comment.


  I think part of the reason why this seems too big also if because it doesn't 
do much more than tell you what day it is. If it was able to integrate with a 
calendar application, it could show appointments. Something like this:
  
  https://goo.gl/images/rwgUw9

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17752: Remove full representation of analog clock

[Marco Martin]

mart added a comment.


  -1, digital and analog clocks have the same scope, and they should have the 
same behavior (if anything it should have the same features of the digital 
clock popup)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17752: Remove full representation of analog clock

[David Edmundson]

davidedmundson added a comment.


  >   User can click in the system tray instead.
  
  Not if they have the analog clock in the system tray instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17752: Remove full representation of analog clock

[Shubham]

shubham created this revision.
shubham added reviewers: hein, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Full representation of analog clock showed a calendar, which does not makes 
sense for two reasons:
  
  1. It shows a massive calendar which clogs the window and looks ugly.
  2. User can click in the system tray instead.

TEST PLAN
  Create analog clock widget. Try to click on it.
  Nothing happens.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cal

REVISION DETAIL
  https://phabricator.kde.org/D17752

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, hein, mart
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart