D18559: Use correct sidebar back button press color

2019-02-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:cad722aa0fa0: Use correct sidebar back button press color 
(authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18559?vs=50363=50651

REVISION DETAIL
  https://phabricator.kde.org/D18559

AFFECTED FILES
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18559: Use correct sidebar back button press color

2019-01-27 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  Makes sense. Please re-base on the stable branch (`Plasma/5.15`) and land 
there, then merge to master.  Instructions are here: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R124 System Settings

BRANCH
  use-correct-sidebar-back-button-press-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18559

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18559: Use correct sidebar back button press color

2019-01-26 Thread Björn Feber
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The system settings currently use a wrong sidebar back button press color, 
which can look very bad on some color schemes (for example Breeze Light), this 
fixes it.
  Before:
  F6569998: Wrong Back Button Press Color.png 

  
  After:
  F656: Correct Back Button Press Color.png 


TEST PLAN
  Open the system settings, click on any category and then press the back 
button.

REPOSITORY
  R124 System Settings

BRANCH
  use-correct-sidebar-back-button-press-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18559

AFFECTED FILES
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart