D18844: Fix opening toolbox button

2019-02-08 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67d8ac416ff6: Use Dialogs visibility directly 
rather than relying on the mainItems (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18844?vs=51160=51164

REVISION DETAIL
  https://phabricator.kde.org/D18844

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, lbeltrame
Cc: davidedmundson, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

2019-02-08 Thread David Edmundson 
davidedmundson added a comment.


  That framework change is released tomorrow, right? Is it worth reverting?  
  Including this, that's at least the second regression it's caused, which 
makes me worry there's even more we haven't found.
  
  > It should have used Dialog's visiblity from the beginning anyway.
  
  It should, so still ship this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

To: broulik, #plasma, lbeltrame
Cc: davidedmundson, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

2019-02-08 Thread Luca Beltrame 
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Works. No side effects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

To: broulik, #plasma, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

2019-02-08 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `Dialog` no longer alters the `mainItem`'s visiblity, so this codepath failed.
  It should have used `Dialog`'s visiblity from the beginning anyway.

TEST PLAN
  5.12?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart