D18859: msvc: First commit

2019-02-08 Thread Nathaniel Graham 
ngraham added a comment.


  Then it should not have been submitted yet, or it should have [WIP] at the 
beginning of the title. :)

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

2019-02-08 Thread patrick j pereira 
patrickelectric added a comment.


  thank you @ngraham, but this is not ready to review yet.
  But be free to review @D18801 and @D18802

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

2019-02-08 Thread Nathaniel Graham 
ngraham added a comment.


  The title and summary sections need to describe what this patch does. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

2019-02-08 Thread patrick j pereira 
patrickelectric updated this revision to Diff 51209.
patrickelectric added a comment.


  - msvc: Add cdb configuration

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18859?vs=51207=51209

BRANCH
  msvc

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

2019-02-08 Thread patrick j pereira 
patrickelectric created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
patrickelectric requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Patrick José Pereira 

REPOSITORY
  R871 DrKonqi

BRANCH
  msvc

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart