D19118: Add (and use) a LinkLabel component

2019-02-19 Thread Aleix Pol Gonzalez
apol added a comment.


  We already have UrlButton for that.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19118

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19118: Add (and use) a LinkLabel component

2019-02-19 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:917819ac26f3: Add (and use) a LinkLabel component 
(authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19118?vs=51956=52041

REVISION DETAIL
  https://phabricator.kde.org/D19118

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/LinkLabel.qml
  discover/qml/ReviewDelegate.qml
  discover/qml/UpdatesPage.qml
  discover/resources.qrc

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19118: Add (and use) a LinkLabel component

2019-02-18 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The component, which is deliberately very simple. just adds the functionality 
to Label of ensuring we have a hand cursor when hovering over a link in the 
Label component. This is required due to missing functionality in both Text and 
QCC2's Label components, which have no mouse cursor changing abilities. There 
is a Qt bug regarding the issue, mentioned in this new component's code, but so 
far it looks unlikely to get a "real" fix anytime soon, so, for less 
headachiness, this component (which simply takes code we already had in one 
place and applies it slightly more widely and generically)...
  
  BUG:404309

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19118

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/LinkLabel.qml
  discover/qml/ReviewDelegate.qml
  discover/qml/UpdatesPage.qml
  discover/resources.qrc

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart