D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Walter Johnson]

wjohnson added a comment.


  If you wish to play with login and lock screen stuff, go to
  
  Main Login
  
  /usr/share/sddm/themes/your-login-theme/main.qml
  
  Lock Screen Login
  
  Helps to know that breeze is the default Plasma lock screen theme. If a lock 
screen is not part of whatever theme you are using, then Plasma will use the 
breeze one.
  
  
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml
  
  In both of those files you will find something like this (I have added the 
corrections):
  
WallpaperFader {

// visible: false keeps from fading the wallpaper
visible: false

// Commenting out "anchors.fill: parent" will also do it.
//anchors.fill: parent

state: lockScreenRoot.uiVisible ? "on" : "off"
source: wallpaper
mainStack: mainStack
footer: footer
clock: clock
}
  
  Either one of those corrections will do the trick. I don't like blurred 
backgrounds on my login screens. They particularly look bad if they are already 
dark pictures.
  
  Anyway, good luck.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: wjohnson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2eec8cb1b505: [sddm-theme/lock screen] Adjust login and 
lock screen blur effect (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19409?vs=52930&id=52931

REVISION DETAIL
  https://phabricator.kde.org/D19409

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty updated this revision to Diff 52930.
rooty added a comment.


  Roll back preview change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19409?vs=52872&id=52930

BRANCH
  arcpatch-D19409

REVISION DETAIL
  https://phabricator.kde.org/D19409

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422811 , @ngraham wrote:
  
  > You know, it occurs to me that we should probably change the previews after 
we're done with all of this, or else each patch will need its own adjusted 
preview images! Sorry to have steered you wrong there. Remove the preview 
change and let's get this landed! Such a big improvement.
  
  
  Haha sure thing, we can just submit a final patch with all the previews?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  You know, it occurs to me that we should probably change the previews after 
we're done with all of this, or else each patch will need its own adjusted 
preview images! Sorry to have steered you wrong there. Remove the preview 
change and let's get this landed! Such a big improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  Okay, then I'll just update the preview here seeing as there's nothing else 
to be done here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  Let's do that separately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422572 , @ngraham wrote:
  
  > Yeah, that doesn't look great. :/
  >
  > For elements like the actionbuttons and the username that will always 
appear over a blur, I guess we should abandon the text shadows. For the clock 
that //sometimes// has a shadow, what we should probably do is make the 
shadow's opacity property public (defaulting to 0.0) and have only the lock 
screen turn it on when there's no blur. Then when the UI controls and blur 
appear, it can set that to off. Then you can add an opacity animator to the 
clock itself so that the shadows's visibility animates when turned on and off.
  
  
  Should I make all of that part of the same patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  Yeah, that doesn't look great. :/
  
  For elements like the actionbuttons and the username that will always appear 
over a blur, I guess we should abandon the text shadows. For the clock that 
//sometimes// has a shadow, what we should probably do is make the shadow's 
opacity property public (defaulting to 0.0) and have only the lock screen turn 
it on when there's no blur. Then when the UI controls and blur appear, it can 
set that to off. Then you can add an opacity animator to the clock itself so 
that the shadows's visibility animates when turned on and off.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Filip Fila]

filipf added a comment.


  In D19409#422453 , @rooty wrote:
  
  > In D19409#422361 , @filipf wrote:
  >
  > > In D19409#422203 , @rooty 
wrote:
  > >
  > > > Should we keep the UserDelegate.qml shadow then? Because it doesn't 
seem necessary considering the blur's here to stay.
  > >
  > >
  > > I think they're unnecessary. There's also a bug they cause in 5.15:
  > >
  > > F6646372: image.png 
  >
  >
  > Ouch, nasty bug
  
  
  Yeah, even if you make the shadow color backgroundColor again it's not good 
to have white "shadows":
  
  F6646619: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422361 , @filipf wrote:
  
  > In D19409#422203 , @rooty wrote:
  >
  > > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem 
necessary considering the blur's here to stay.
  >
  >
  > I think they're unnecessary. There's also a bug they cause in 5.15:
  >
  > F6646372: image.png 
  
  
  Ouch, nasty bug

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Filip Fila]

filipf added a comment.


  In D19409#422203 , @rooty wrote:
  
  > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem 
necessary considering the blur's here to stay.
  
  
  I think they're unnecessary. There's also a bug they cause in 5.15:
  
  F6646372: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422264 , @ngraham wrote:
  
  > 1996? 😆
  
  
  https://kde.org/announcements/announcement.php
  It seemed preferable to some random date
  
  Didn't know about the lock screen preview image... interesting
  
  > TBH I kind of like the shadows on top of the blur--especially with your new 
much nicer-looking shadows!
  > 
  > When SDDM uses software rendering, the shadow disappears unless we 
specifically handle that case and draw an outline instead.
  
  In that case, we should consider adding action button label shadows as well.
  I wasn't asking about the shadows though, I was asking about what happens to 
the **blur** if sddm uses software rendering - because if the software rendered 
version's blurry too, we might not need a text outline at all.
  
  P.S. The time stands for a very important date too :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  In D19409#422203 , @rooty wrote:
  
  > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem 
necessary considering the blur's here to stay.
  >
  > P.S. What happens to the blur if sddm defaults to software rendering?
  >
  > EDIT: I know I just landed it but there was also the clock shadow there and 
I really like that new clock shadow :D
  
  
  TBH I kind of like the shadows on top of the blur--especially with your new 
much nicer-looking shadows!
  
  When SDDM uses software rendering, the shadow disappears unless we 
specifically handle that case and draw an outline instead.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  1996? 😆
  
  Also the lock screen has a preview image too: 
`plasma-workspace/lookandfeel/contents/previews/lockscreen.png`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty updated this revision to Diff 52872.
rooty added a comment.


  Add second user (Katie) to preview

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19409?vs=52871&id=52872

BRANCH
  adjust-blur (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19409

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart