D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy marked an inline comment as done.
tagorechandanreddy added inline comments.

INLINE COMMENTS

> davidedmundson wrote in noaaprovider.cpp:93
> Why are we losing multiline?

The new string pattern doesn't need Multiline option. It handles newline 
character.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> noaaprovider.cpp:93
>  QString url;
> -QRegularExpression re(QStringLiteral("a href='(.*)'> QRegularExpression::MultilineOption);
> +QRegularExpression 
> re(QStringLiteral("a//s+href='(.*)'//s*>[//s//n]* QRegularExpression::CaseInsensitiveOption);
>  auto result = re.match(data);

Why are we losing multiline?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  This patch is meant to be a more complete solution to handle the random HTML 
changes on the webpage. Without this patch, the plugin fails on odd occasions 
as the webpage gets updated daily.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Nathaniel Graham]

ngraham added a comment.


  In D19419#424176 , 
@tagorechandanreddy wrote:
  
  > The HTML of the webpage is updated with random whitespace characters and 
newline characters.
  
  
  But does that make it actually not work at the moment?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  The HTML of the webpage is updated with random whitespace characters and 
newline characters. Henceforth, this patch handles any such changes.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Nathaniel Graham]

ngraham added a comment.


  Can you clarify what problem we're solving here? The NOAA picture of the day 
wallpaper currently works just fine for me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy created this revision.
tagorechandanreddy added reviewers: ngraham, davidedmundson.
tagorechandanreddy added a project: Plasma.
tagorechandanreddy requested review of this revision.

REVISION SUMMARY
  'Image of the day' has a new landing page everyday. This patch fixes the 
RegEx string that fetches the web address of the landing page.

TEST PLAN
  All plugins should work as usual.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart