D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham updated this revision to Diff 52921.
ngraham added a comment.


  Make it configurable and don't change the default behavior

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19444?vs=52903&id=52921

BRANCH
  scrollable-humongous-menus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19444

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Guido Sanchez]

guidosanchez added a comment.


  Maybe making it configurable would make most users happy :)
  
  Another unexpected behavior in this issue is that if you are using the Global 
Menu widget, the emerging menu (that supposedly doesn't fit the screen) 
shouldn't cover the panel that has the Global Menu widget.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  What he complains about is that items are unreachable. Yes, it should scroll. 
Either horizontally or vertically. A scrollbar would be perfect so you see how 
much you don't see. In addition to multiple columns, if there are 1½ or more.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Noah Davis]

ndavis added a comment.


  Horizontal menus are fast, but unusable or hard to read if they get too 
large. Scrollable menus with the arrows that you hover over are annoyingly slow 
if you don't use a scroll wheel to scroll, but don't block the entire screen if 
you have a large number of items. In both cases, the best solution from the 
user's end is to make more folders so that the list doesn't overflow.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham added a comment.


  In D19444#422559 , @cfeck wrote:
  
  > The problem is that adding this property limits to a single column.
  
  
  Yeah, that's the point. :)
  
  In D19444#422559 , @cfeck wrote:
  
  > For a menu that only has a few more items than fit in a column this is 
acceptable, but for the menu in the referenced ticket it is not.
  
  
  Well the person who filed that ticket clearly didn't find the expandable menu 
acceptable, or else they wouldn't have filed it! :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  The problem is that adding this property limits to a single column. It should 
show all columns, and additionally allow the user to scroll. For a menu that 
only has a few more items than fit in a column this is acceptable, but for the 
menu in the referenced ticket it is not.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham added a comment.


  In D19444#422556 , @davidedmundson 
wrote:
  
  > FWIW, there is a way to do it on a per-menu basis using a combination of
  >
  > QWidget::setStyle and QProxyStyle
  
  
  Not sure that would really help in this specific case since the bug reporter 
wants his bookmarks menu to be scrollable rather than expanding, while @cfeck 
wants the same menu to be expanding rather than scrollable!
  
  I suppose (sigh) I could make it configurable...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[David Edmundson]

davidedmundson added a comment.


  FWIW, there is a way to do it on a per-menu basis using a combination of
  
  QWidget::setStyle and QProxyStyle

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[Michail Vourlakos]

mvourlakos added a comment.


  This issue has an origin from : 
https://github.com/psifidotos/applet-window-appmenu/issues/45
  
  menus  dont respect the available screen size

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  Please not. I use wide menus extensively, e.g. for bookmarks, and are not 
keen to wait eons to find an item because of the slow scrolling.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Breeze, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 404942
  FIXED-IN: 5.15.03

TEST PLAN
  In a VM, make the screen size tiny, Open Dolphin, and open its Control menu
  
  Before: F6646888: Before.png 
  
  After: F6646890: After.png 

REPOSITORY
  R31 Breeze

BRANCH
  scrollable-humongous-menus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19444

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #breeze, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart