D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Björn Feber]

GB_2 added a comment.


  In D19472#427613 , @ngraham wrote:
  
  > In D19472#427046 , @broulik 
wrote:
  >
  > > This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.
  >
  >
  > So I see. :(
  >
  > I guess we really gotta figure out how to call 
`plasmoid.contextualActionsAboutToShow();` before a different context menu 
appears.
  
  
  Yeah, I think @davidedmundson has it on his TODO list, I asked him at a 
monday meeting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: GB_2, abetts, broulik, rooty, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

ngraham added a comment.


  In D19472#427046 , @broulik wrote:
  
  > This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.
  
  
  So I see. :(
  
  I guess we really gotta figure out how to call 
`plasmoid.contextualActionsAboutToShow();` before a different context menu 
appears.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: abetts, broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Andres Betts]

abetts added a comment.


  Can it be more descriptive? Using two words might help it be extra clear what 
the button is about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: abetts, broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Kai Uwe Broulik]

broulik added a comment.


  This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd7b359f8461: [Task Manager] Make sure 
"Alternatives..." context menu item is always available (authored by 
ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19472?vs=52980&id=52983

REVISION DETAIL
  https://phabricator.kde.org/D19472

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  You have no idea how much of a headache not having this option has been 
huge +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  task-manager-alternatives-in-item-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, the Task Manager does not show the Alternatives... item in the 
context
  menu for tasks, so it's inaccessible when the Task Manager is full. This 
patch fixes
  that.
  
  BUG: 404969
  FIXED-IN: 5.15.3

TEST PLAN
  - Menu item is visible in the context menu for individual tasks when widgets 
are unlocked
  - Menu item is hidden when widgets are locked
  - Menu item works, and shows the Alternatives panel when clicked
  - No duplication in context menu for an empty area of the Task Manager

REPOSITORY
  R119 Plasma Desktop

BRANCH
  task-manager-alternatives-in-item-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19472

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart