D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:99dd92635f27: [Lock, Login, and Logout screen] Adjust 
visual feedback of action buttons (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53360=53397

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf added a comment.


  In D19479#426481 , @rooty wrote:
  
  > These screenshots might make this problem more appreciable.
  >
  > OpacityAnimator:
  >
  > F6669246: image.png 
  >
  > (Sleep darker than the other buttons, certain other buttons become dark on 
hover then turn white, I can't explain why)
  >
  > PropertyAnimation:
  >
  > F6669252: image.png 
  >
  > (Sleep has the same opacity and color as the other buttons - there are no 
circumstances under which the buttons turn dark, and any one button is just as 
bright as any of the other buttons)
  
  
  I can't spot this IRL (might depend on the screen). But when you pause it I 
do see that "Sleep" lags behind the other buttons when switching the screens 
and using OpacityAnimator.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf updated this revision to Diff 53360.
filipf added a comment.


  divide radius with 2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53356=53360

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Krešimir Čohar 
rooty added a comment.


  These screenshots might make this problem more appreciable.
  
  OpacityAnimator:
  
  F6669246: image.png 
  
  (Sleep darker than the other buttons, certain other buttons become dark on 
hover then white, I can't explain why)
  
  PropertyAnimation:
  
  F6669252: image.png 
  
  (Sleep has the same opacity and color as the other buttons - there are no 
circumstances under which the buttons turn dark, and any one button is just as 
bright as any of the other buttons)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Krešimir Čohar 
rooty added a comment.


  In D19479#426474 , @davidedmundson 
wrote:
  
  > Visual indication on mouseover is generally a good thing ++
  
  
  It's this problem (keep your eye on Sleep)
  
  F6655268: consequences-of-advanced-spellcasting.mp4 

  
  It occurs with OpacityAnimator but not PropertyAnimation

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread David Edmundson 
davidedmundson added a comment.


  Visual indication on mouseover is generally a good thing ++

INLINE COMMENTS

> ActionButton.qml:44
> +Behavior on opacity {
> +PropertyAnimation { // OpacityAnimator makes it turn black at 
> random intervals
> +duration: units.longDuration * 2

I ran with:

  opacity: activeFocus || containsMouse ? 1 : 0.85
  Behavior on opacity {
  OpacityAnimator { // OpacityAnimator makes it turn black at random 
intervals
  duration: units.longDuration * 2
  easing.type: Easing.InOutQuad
  }
  }

on my system, worked fine. Can you give any more details on "randomly"

> ActionButton.qml:55
> +height: width
> +radius: width
> +color: PlasmaCore.ColorScope.textColor

width/2

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf added a comment.


  Anyone from #plasma  have an opinion 
on the code or functionality?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf updated this revision to Diff 53356.
filipf added a comment.


  Actually fix comment: "intervals" -> "random intervals"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53355=53356

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Krešimir Čohar 
rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  Perfect

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf updated this revision to Diff 53355.
filipf added a comment.


  fix comment: "intervals" -> "random intervals"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53354=53355

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf updated this revision to Diff 53354.
filipf added a comment.


  replace yet another OpacityAnimator with PropertyAnimation and explain why

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53353=53354

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-07 Thread Filip Fila 
filipf updated this revision to Diff 53353.
filipf added a comment.


  replace OpacityAnimator with PropertyAnimation and explain why

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53325=53353

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Krešimir Čohar 
rooty requested changes to this revision.
rooty added a comment.
This revision now requires changes to proceed.


  I really hate to be a bore but without the switch to PropertyAnimation that 
annoying bug (that you might not be able to notice but I am) keeps rearing its 
ugly head.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  This looks and feels great to me! A huge improvement IMO. And the code looks 
good.
  
  I'd also like a pressed state for these buttons too, but since the lack of 
them is a pre-existing issue, we can do that in another patch. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Filip Fila 
filipf updated this revision to Diff 53325.
filipf added a comment.


  fix comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53322=53325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> LogoutButton.qml:34
> +circleVisiblity: activeFocus || containsMouse
> +circleOpacity: 0.15 // circles are always visible
>  opacity: activeFocus || containsMouse ? 1 : 0.5

This comment doesn't seem accurate anymore.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Filip Fila 
filipf updated this revision to Diff 53322.
filipf added a comment.


  go back to using opacityanimator

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53321=53322

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-06 Thread Filip Fila 
filipf updated this revision to Diff 53321.
filipf added a comment.


  Circles in the logout screen are only visible if the option is selected or 
hovered over

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53089=53321

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-04 Thread Filip Fila 
filipf added a comment.


  In D19479#424236 , @davidedmundson 
wrote:
  
  > > Could we use QtRendering to work around the issue until the patch lands?
  >
  > Go for it. Add a comment why we're doing it
  
  
  Thanks! Done in D19510 
  
  As for this diff I now also find myself favoring circles appearing only on 
hover in the login and lock screens. While there is merit to consistency, I 
don't think the buttons there are of that great of an importance as in the 
logout screen. We also don't need to be solving any legibility issue.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-04 Thread David Edmundson 
davidedmundson added a comment.


  > Could we use QtRendering to work around the issue until the patch lands?
  
  Go for it. Add a comment why we're doing it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-04 Thread Krešimir Čohar 
rooty added a comment.


  If I use PropertyAnimation instead of OpacityAnimator, the opacity problem 
seems to go away. Can anyone confirm?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-03 Thread Krešimir Čohar 
rooty added a comment.


  The animator causes a little bit of a problem (keep your eye on the Sleep 
button):
  
  F6655268: consequences-of-advanced-spellcasting.mp4 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

2019-03-03 Thread Filip Fila 
filipf added a subscriber: davidedmundson.
filipf added a comment.


  @davidedmundson we have some considerable issues with text opacity failing 
when the logout screen is superimposed over a light background:
  
  F6655046: image.png 
  
  You mentioned something about sending in a Qt patch for this in the bug 
report . Could we use QtRendering 
to work around the issue until the patch lands?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart