D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
This revision was automatically updated to reflect the committed changes. Closed by commit R114:1a171706e7b3: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19664?vs=53824=53843 REVISION DETAIL https://phabricator.kde.org/D19664 AFFECTED FILES applets/quickshare/plasmoid/contents/config/config.qml applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml To: filipf, #vdg, #plasma, apol, ngraham Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
filipf added a comment. ^ Also I may have may the window wider in the pic than it would be normally REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma, apol, ngraham Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
ngraham accepted this revision. ngraham added a comment. I think it looks fine, actually. Visually, the only change is centering the controls rather than left-aligning them. And the page already has a title. REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma, apol, ngraham Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
abetts added a comment. While it makes sense to change it to the new form, the alignment feels odd because there are just a couple of items in the kcm. I wonder if having a title label would help ground the elements on the page. REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma, apol, ngraham Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
filipf updated this revision to Diff 53824. filipf added a comment. be conservative with imports and don't use a top level Item REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19664?vs=53623=53824 BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 AFFECTED FILES applets/quickshare/plasmoid/contents/config/config.qml applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml To: filipf, #vdg, #plasma, apol, ngraham Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Awesome thanks! REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma, apol Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 AFFECTED FILES applets/quickshare/plasmoid/contents/config/config.qml applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml To: filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
