D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham added a comment.


  The "after" version is already in the wild because of a Kirigami Frameworks 
change to make list items shorter, and I haven't seen any user complaints at 
all about it. In fact, I've seen a few positive ones. So I'm going to land this 
and preserve the current status quo since it seems to be working fine.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: filipf, ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:f8a9bdfdd7bf: [RFC] Reduce sidebar icon size/increase 
list information density (authored by ngraham).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19694?vs=53693&id=56830

REVISION DETAIL
  https://phabricator.kde.org/D19694

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, #vdg
Cc: filipf, ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Filip Fila]

filipf added a comment.


  > Ever since increasing the list item size to accommodate 32px icons, System 
Settings' sidebar has felt somehow wrong to me
  
  Same here, I prefer this patch rather than the bigger icons. Since we're 
still having issues with monochrome issues showing up, obviously the question 
is what do we want to solve at this moment. I'd be more in favor of 
prioritizing reduced information density, but we definitely need more opinions 
and discussion on this.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: filipf, ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Noah Davis]

ndavis added a comment.


  In D19694#434169 , @ngraham wrote:
  
  > I was talking about the problem of small monochrome icons in the sidebar 
itself, not in the tooltip. But anyway since then I fixed the tooltip too.
  >
  > Any more #VDG  or #plasma 
 opinions on this?
  
  
  I was talking about the sidebar as well, but I think I misunderstood what you 
were saying.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham added a comment.


  I was talking about the problem of small monochrome icons in the sidebar 
itself, not in the tooltip. But anyway since then I fixed the tooltip too.
  
  Any more #VDG  or #plasma 
 opinions on this?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Noah Davis]

ndavis added a comment.


  > Though the icons are indeed pretty, and the
  
  problem with small monochrome icons has been resolved, the information 
density is now
  quite low.
  
  When? I still get a mix of color and monochrome icons in System Settings with 
the git master versions of it and its dependencies.
  
  I agree that the side bar looks better with shorter items, but I don't think 
we should make a change like this before the problem is really solved.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham added a comment.


  In D19694#429341 , @broulik wrote:
  
  > Not a huge fan of going back and forth with design decisions all the time 
but +1 I preferred the smaller icons we used to habe
  
  
  //Technically// this isn't actually going back to anything because in the 
past we had small icons with tall list items--the worst of both worlds. Now we 
have tall list items with large icons, and this turns it into short list items 
with small icons. Also this hasn't been released to customers yet. If you can't 
do your experimenting in git master, where can you do it? :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Kai Uwe Broulik]

broulik added a comment.


  Not a huge fan of going back and forth with design decisions all the time but 
+1 I preferred the smaller icons we used to habe

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Ever since increasing the list item size to accommodate 32px icons, System 
Settings'
  sidebar has felt somehow //wrong// to me. Though the icons are indeed pretty, 
and the
  problem with small monochrome icons has been resolved, the information 
density is now
  quite low. Since the list is very long, the amount of scrolliness is 
increased and
  there's a low of whitespace.
  
  This RFC patch explores the impact of reducing the icon size down to the 
default value
  for Kirigami list items. The information density increases and the whole 
thing feels
  better to me. On the other hand, the icons don't look as good because they're 
scaled to
  fit in a 22px size. Also, touch-friendliness is reduced.
  
  I'm not married to this idea but I thought I'd throw it out there. Comments 
are welcome.

TEST PLAN
  Before: F6685010: Before.png 
  After: F6685009: After.png 

REPOSITORY
  R124 System Settings

BRANCH
  reduce-sidebar-icon-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19694

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart