D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:e32e12df50d3: [fuzzy-clock] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19747?vs=53893=53927

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks. I can confirm the bug not only here but in the wild in our libinput 
mouse and touchpad KCMs. The workaround seems sane for now.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Filip Fila 
filipf added a comment.


  In D19747#430961 , @ngraham wrote:
  
  > We'll need a bug report on this slider issue if we're gonna work around it, 
at a minimum.
  
  
  Done: https://bugs.kde.org/show_bug.cgi?id=405471

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Filip Fila 
filipf updated this revision to Diff 53893.
filipf added a comment.


  link the bug report for qqc2 slider

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19747?vs=53854=53893

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Nathaniel Graham 
ngraham added a comment.


  We'll need a bug report on this slider issue if we're gonna work around it, 
at a minimum.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-14 Thread Filip Fila 
filipf added a comment.


  Unless I'm doing something wrong, QQC2 Slider seems broken when 
`minimumValue` aka `from` is 1:
  
import QtQuick.Controls 2.5
Slider {
from: 1
to: 5
stepSize: 1
}

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-13 Thread Filip Fila 
filipf planned changes to this revision.
filipf added a comment.


  Unforunately I'm getting bad stepSize behavior with the QQC2.Slider. It's 
reproducible even when keeping the original code and only porting the slider to 
QQC2 (that entails "from", "to", and removing "tickmarks"). If we can't get it 
to work we probably still need to document the issue better.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-13 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart