D19826: kns: Show subcategories for things that have one
This revision was automatically updated to reflect the committed changes. Closed by commit R134:3dfd7cbc8e4b: kns: Show subcategories for things that have one (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19826?vs=54219&id=54227 REVISION DETAIL https://phabricator.kde.org/D19826 AFFECTED FILES libdiscover/backends/KNSBackend/KNSBackend.cpp To: apol, #discover_software_store, leinir Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19826: kns: Show subcategories for things that have one
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Nifty :) REPOSITORY R134 Discover Software Store BRANCH arcpatch-D19826_1 REVISION DETAIL https://phabricator.kde.org/D19826 To: apol, #discover_software_store, leinir Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19826: kns: Show subcategories for things that have one
apol updated this revision to Diff 54219. apol added a comment. Rebase and test with opendesktop apps REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19826?vs=54085&id=54219 BRANCH arcpatch-D19826_1 REVISION DETAIL https://phabricator.kde.org/D19826 AFFECTED FILES libdiscover/backends/KNSBackend/KNSBackend.cpp To: apol, #discover_software_store, leinir Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19826: kns: Show subcategories for things that have one
leinir requested changes to this revision.
leinir added a comment.
The rest looks nice and solid :)
INLINE COMMENTS
> KNSBackend.cpp:161
> +if (cats.count() > 1) {
> +m_categories += cats;
> +for(const auto &cat: cats) {
Don't think we need this, already creating the categories as Category instances
just below, and we set the category on the Resource instance when we create
that in ::resourceForEntry... With it we'd end up duplicating those categories
in the list of categories for all resources, from what i can tell this line
just isn't needed :)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D19826
To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19826: kns: Show subcategories for things that have one
apol planned changes to this revision. apol added a comment. Should look into whether it works for installed packages. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19826 To: apol, #discover_software_store Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19826: kns: Show subcategories for things that have one
apol created this revision. apol added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show subcategories for KNS resources that have more than 1 Category inside. At the moment it just is Wallpapers. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D19826 AFFECTED FILES libdiscover/backends/KNSBackend/KNSBackend.cpp To: apol, #discover_software_store Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
