D19829: kicker: add option to make root level icons visible

2019-06-01 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f5ad1bfc33a4: kicker: add option to make root level icons 
visible (authored by i.Dark_Templar, committed by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19829?vs=57202&id=58970

REVISION DETAIL
  https://phabricator.kde.org/D19829

AFFECTED FILES
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/plugin/rootmodel.cpp

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-05-31 Thread Aleksei Nikiforov 
i.Dark_Templar added a comment.


  In D19829#472621 , @ngraham wrote:
  
  > @i.Dark_Templar can you land this yourself?
  
  
  I don't think I have access for that. Also I don't have Arc at the moment, 
and there's no indication in web interface that I have capability to do it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-05-31 Thread Nathaniel Graham 
ngraham added a comment.


  @i.Dark_Templar can you land this yourself?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-05-31 Thread Eike Hein 
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  I'm still a bit grumpy about this and dragging my feet! My gut still says 
it's both option clutter and UI noise :-)
  
  However:
  
  - There's a fair amount of people calling for this now.
  - The underlying code is already there.
  - Since the codepath is already in, it's more likely to bitrot when there 
isn't a GUI option that allows testing it.
  
  It's a go.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-05-30 Thread Björn Feber 
GB_2 added a comment.


  Ping @hein

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-05-09 Thread Björn Feber 
GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-29 Thread Nathaniel Graham 
ngraham added 1 blocking reviewer(s): hein.
ngraham added a comment.
This revision now requires review to proceed.


  Ultimately it's up to @hein as the maintainer. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-29 Thread Björn Feber 
GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Works great.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-29 Thread Aleksei Nikiforov 
i.Dark_Templar updated this revision to Diff 57202.
i.Dark_Templar added a comment.


  Rebased to master, but it needs testing.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19829?vs=54094&id=57202

REVISION DETAIL
  https://phabricator.kde.org/D19829

AFFECTED FILES
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/plugin/rootmodel.cpp

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-29 Thread Björn Feber 
GB_2 added a comment.


  I would accept it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-29 Thread Aleksei Nikiforov 
i.Dark_Templar added a comment.


  In D19829#456234 , @GB_2 wrote:
  
  > Can you please update this patch? It doesn't apply anymore. It would also 
be nice if you used Arcanist/`arc` in the future: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  
  Is it going to be merged? Otherwise, there's no point in updating it here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-25 Thread Björn Feber 
GB_2 added a comment.


  Can you please update this patch? It doesn't apply anymore. It would also be 
nice if you used Arcanist/`arc` in the future: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-12 Thread Björn Feber 
GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-04-02 Thread Björn Feber 
GB_2 added a comment.


  In D19829#432852 , @i.Dark_Templar 
wrote:
  
  > Favorite icons are much larger, it's hard to confuse them with root level 
menu icons. If it's deemed as informational noise, it's disabled by default. 
But in case it's not, it may be enabled if this change is applied. And in my 
opinion it looks more consistent in style with 'modern menu' since 'modern 
menu' has those icons enabled.
  >
  > Edit: and it looks more consistent with menu editor which show those root 
level icons. It looks weird for me when menu editor shows those icons but menu 
does not.
  
  
  I would personally like to have this feature.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov 
i.Dark_Templar added a comment.


  Favorite icons are much larger, it's hard to confuse them with root level 
menu icons. If it's deemed as informational noise, it's disabled by default. 
But in case it's not, it may be enabled if this change is applied. And in my 
opinion it looks more consistent in style with 'modern menu' since 'modern 
menu' has those icons enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Eike Hein 
hein added a comment.


  Kicker intentionally doesn't have icons on the root level to not conflict 
with the favorites column and reduce visual noise.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov 
i.Dark_Templar added a comment.


  Attaching screenshot with current look of menu (or with disabled option) and 
new look with enabled option and also a configuration widget.
  F6698363: kde-menu-changes.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Nathaniel Graham 
ngraham added reviewers: Plasma, VDG.
ngraham added a comment.


  Screenshots are always appreciated for changes to the UI. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov 
i.Dark_Templar created this revision.
i.Dark_Templar added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
i.Dark_Templar requested review of this revision.

REVISION SUMMARY
  In file applets/kicker/package/contents/config/main.xml an option 
'showIconsRootLevel' is mentioned. It has following description:
  "Whether to show icons on the root level of the menu."
  
  This change provides implementation for this option.

TEST PLAN
  Manual test:
  
  1. Change menu to 'classic menu' (kicker), notice root level menu items have 
no icons
  2. Open menu settings widget
  3. Notice new checkbox 'Show icons on the root level of the menu'
  4. Check that checkbox and hit 'Apply' button
  5. Root menu items should now have icons similar which look similar to icons 
in 'modern menu' (kickoff)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

AFFECTED FILES
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/plugin/rootmodel.cpp

To: i.Dark_Templar, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart