D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4516ab53726c: [image-wallpaper] Port to 
Kirigami.FormLayout and use twinFormLayouts (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=55283&id=55387

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart, hein
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Marco Martin]

mart accepted this revision.
mart added a comment.


  I think the patch is fine, the extra spacing is probably in the shell package
  
plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  
  you can take a look there and see where things are
  
  maybe gammaray is also helpful in it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  In D19873#442385 , @hein wrote:
  
  > Looks solid to me. Is your concern re vertical spacing still valid?
  
  
  Thanks for having a look. Vertical spacing in wallpaper plugins is now OK, 
but unfortunately the spacing is always too big where the master layout and the 
individual wallpaper plugin meet:
  
  F6747169: image (1)spacing.png 
  
  I tried removing a bunch of items in both files thinking they may be be 
adding to the height of the form, but it didn't seem to help.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Eike Hein]

hein added a comment.


  Looks solid to me. Is your concern re vertical spacing still valid?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  I think it would be good if someone from #plasma 
 could have a look if this is okay, I 
did do a lot of modifications.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55283.
filipf added a comment.


  .

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=55282&id=55283

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55282.
filipf added a comment.


  git...

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=55281&id=55282

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop
  kcms/translations/kcm_translations.desktop
  kcms/translations/package/metadata.desktop
  klipper/klipper.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/metadata.desktop
  menu/desktop/kf5-games-kids.directory
  sddm-theme/Main.qml
  sddm-theme/metadata.desktop
  sddm-theme/preview.png
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelshadows.cpp
  shell/panelshadows_p.h
  shell/panelview.cpp
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55281.
filipf added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54797&id=55281

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop
  kcms/translations/kcm_translations.desktop
  kcms/translations/package/metadata.desktop
  klipper/klipper.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/metadata.desktop
  menu/desktop/kf5-games-kids.directory
  sddm-theme/Main.qml
  sddm-theme/metadata.desktop
  sddm-theme/preview.png
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelshadows.cpp
  shell/panelshadows_p.h
  shell/panelview.cpp
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54797.
filipf added a comment.


  Don't break the slideshow wallpaper by putting everything in a form layout

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54790&id=54797

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54790.
filipf added a comment.


  lose the unecessary QtQuick.Controls 1 import

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54554&id=54790

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This works great with D19932 . Definitely 
seems like the correct fix. The rest of the code changes look good too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54554.
filipf added a comment.


  make the "Folders" string translatable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54484&id=54554

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  I've done a lot of clean up because: (1) some code is not needed for the 
FormLayout; (2) things worked the same without some code; (3) ported the 
combobox to QQC2 because the main layout is also using QQC2 comboboxes and 
everything still fits with normal scaling.
  
  Let me know if I've gone too far.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol