D19890: Changes the drawing of QToolButton inline indicator arrows

[Nathaniel Graham]

ngraham added a comment.


  Thanks very much for this patch! I will review sometime in the next 48 hours.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

[David Hallas]

hallas added a comment.


  Hi @ngraham ,
  
  I have made this separate change to discuss the redesign of the indicator 
arrows. The current patch changes the indicator arrow so that the toolbutton 
stays the same size and the indicator arrow is drawn as a two pixel arrow with 
one pixel margin to the border. Below is some screen shots:
  
  Indicator arrow size 2 pixels:
  
  F6702221: two_pixels_wide_one_pixel_margin_big.png 

  
  F6702225: two_pixels_wide_one_pixel_margin.png 

  
  I also did a test with a 3 pixel arrow size:
  
  F6702227: three_pixels_wide_big.png 
  
  F6702229: three_pixels_wide.png 
  
  Finally, the before picture:
  
  F6702233: original.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

[David Hallas]

hallas created this revision.
hallas added reviewers: VDG, Breeze, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Changes the drawing of inline indicators with QToolButtons so that it
  is drawn as a small arrow in the lower right corner.

TEST PLAN
  Show QToolButton with Menu and PopupDelay enabled

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart