D19924: [TabBar] Update height when TabButtons are added dynamically
This revision was automatically updated to reflect the committed changes. Closed by commit R858:4cc5649da9b6: [TabBar] Update height when TabButtons are added dynamically (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19924?vs=54442=56878 REVISION DETAIL https://phabricator.kde.org/D19924 AFFECTED FILES org.kde.desktop/TabBar.qml To: broulik, #plasma, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19924: [TabBar] Update height when TabButtons are added dynamically
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. the code looks super weird but yeah, seems needed :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19924 To: broulik, #plasma, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19924: [TabBar] Update height when TabButtons are added dynamically
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When using a `Repeater` with an asynchronously populated model `TabBar` fails to initially get a height. TEST PLAN - Used a `Repeater` with `ActivitiesModel` wired up to a `TabBar`, previously didn't get a height, now it gets a height - KWin decoration KCM (which uses hardcoded `TabButtons`) still works fine REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19924 AFFECTED FILES org.kde.desktop/TabBar.qml To: broulik, #plasma, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
