D19940: always support all command line options
This revision was automatically updated to reflect the committed changes. Closed by commit R871:abc37a6aef2d: always support all command line options (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19940?vs=54480&id=55887#toc REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19940?vs=54480&id=55887 REVISION DETAIL https://phabricator.kde.org/D19940 AFFECTED FILES src/main.cpp To: sitter, #plasma, apol Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D19940: always support all command line options
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R871 DrKonqi BRANCH arbitrary-options REVISION DETAIL https://phabricator.kde.org/D19940 To: sitter, #plasma, apol Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D19940: always support all command line options
sitter added a comment. I should add for the record that I'd actually find stricter versioning better, but arg handling in kcrash is already a bit tricky because of signal-safety restrictions and adding versioning complexity on top would probably do nothing for how easy the code base is to approach. On top of that, even with minimal options (correctly) set, drkonqi will and should be able to help the user file a bug report. In theory we need as little as the pid to do something of use. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19940 To: sitter, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19940: always support all command line options
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY with the current way options are handled we'd always have a tight lock between kcrash and drkonqi making it unnecessarily difficult to add new options because newer kcrashes cannot simply pass them regardless of drkonqi's version. e.g. - drkonqi 5.20 adds --displayName - kcrash 5.70 adds support for passing --displayName - kcrash now needs to somehow determine the precise version of drkonqi because passing --displayName to 5.19 or below results in exit1 by having drkonqi ignore unknown options we can eliminate this restriction as kcrash can then simply always pass all arguments it knows (which it needs to do for the entire so-series; 5.70 needs to still work with plasma 5.0 in theory) NB: 5.x still needs some variant of version checking as kcrash needs to find out if drkonqi has this new behavior. come 6.x we would be able to ignore versions entirely in kcrash TEST PLAN passing arbitrary cli options no longer causes drkonqi to exit in error REPOSITORY R871 DrKonqi BRANCH arbitrary-options REVISION DETAIL https://phabricator.kde.org/D19940 AFFECTED FILES src/main.cpp To: sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
